Skip to content

Conversation

@adambarreiro
Copy link
Contributor

@adambarreiro adambarreiro commented Jan 23, 2025

Adds vcfa_content_library resource + data source and complementary vcfa_storage_class, vcfa_region_storage_policy data sources.

Disclaimer: Tenant content libraries are not tested yet, as it requires modyfing vcfa_org_vdc and PR would be quite big. This feature will come on next PRs.

Ref:

Signed-off-by: abarreiro <[email protected]>
@adambarreiro adambarreiro self-assigned this Jan 23, 2025
#
Signed-off-by: abarreiro <[email protected]>
@adambarreiro adambarreiro changed the title Add vcfa_content_library + vcfa_content_library_item resources and data sources Add vcfa_content_library resource and data source + vcfa_storage_class data source + vcfa_region_storage_policy data source Jan 23, 2025
abarreiro added 10 commits January 23, 2025 11:50
Signed-off-by: abarreiro <[email protected]>
#
Signed-off-by: abarreiro <[email protected]>
#
Signed-off-by: abarreiro <[email protected]>
#
Signed-off-by: abarreiro <[email protected]>
#
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Fix
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
@adambarreiro adambarreiro marked this pull request as ready for review January 23, 2025 14:12
Copy link
Contributor

@Didainius Didainius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few immediate comments

abarreiro added 5 commits January 23, 2025 15:24
Signed-off-by: abarreiro <[email protected]>
#
Signed-off-by: abarreiro <[email protected]>
#
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
abarreiro added 3 commits January 23, 2025 16:38
Fix
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Copy link

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried manually. Thanks!

@adambarreiro adambarreiro merged commit 623ac7b into vmware:main Jan 24, 2025
2 checks passed
@adambarreiro adambarreiro deleted the content-library branch January 24, 2025 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants