Skip to content

Add vcfa_org_regional_networking_vpc_qos resource and data source #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Didainius merged 26 commits into from
Jan 30, 2025
Merged

Add vcfa_org_regional_networking_vpc_qos resource and data source #20

Didainius merged 26 commits into from
Jan 30, 2025

Conversation

@Didainius
Copy link
Contributor

@Didainius Didainius commented Jan 28, 2025 •
edited
Loading

  • New Resource: vcfa_org_regional_networking_vpc_qos to manage Org Regional Networking VPC QoS
  • New Data Source: vcfa_org_regional_networking_vpc_qos to read Org Regional Networking VPC QoS

@Didainius
Add vcfa_org_networking resource + data source
386ce1d 
Signed-off-by: Dainius <[email protected]>
@Didainius
Patch test, changelog
73294fd 
Signed-off-by: Dainius <[email protected]>
@Didainius
Self review, tests
c5a8d9f 
Signed-off-by: Dainius <[email protected]>
@Didainius
Latest govcd
4925f9e 
Signed-off-by: Dainius <[email protected]>
@Didainius
make static
16ae54d 
Signed-off-by: Dainius <[email protected]>
@Didainius
WIP
ab31557 
Signed-off-by: Dainius <[email protected]>
@Didainius
Merge branch 'main' into org-region-network
7761973 
Signed-off-by: Dainius <[email protected]>
@Didainius
Fix go.mod
08cddf0 
Signed-off-by: Dainius <[email protected]>
@Didainius
WIP
3ccd226 
Signed-off-by: Dainius <[email protected]>
@Didainius
Update config sample
1cb887e 
Signed-off-by: Dainius <[email protected]>
@Didainius
Merge branch 'main' into org-region-network
cfd9e5b 
Signed-off-by: Dainius <[email protected]>
@Didainius
Self review
94be0df 
Signed-off-by: Dainius <[email protected]>
@Didainius
WIP
e789481 
Signed-off-by: Dainius <[email protected]>
@Didainius
Add test and fix bug in code
4c3a52b 
Signed-off-by: Dainius <[email protected]>
@Didainius
Patch test
3e1ea2e 
Signed-off-by: Dainius <[email protected]>
@Didainius
Add docs
f0e5330 
Signed-off-by: Dainius <[email protected]>
@Didainius
Bump SDK
92ca43f 
Signed-off-by: Dainius <[email protected]>
@Didainius
Merge branch 'main' into org-region-network-vpc-qos
6ecbf2d 
Signed-off-by: Dainius <[email protected]>
@Didainius
Fix HCL
b3450b5 
Signed-off-by: Dainius <[email protected]>
@Didainius
changelog
7acf222 
Signed-off-by: Dainius <[email protected]>
@Didainius Didainius marked this pull request as ready for review January 29, 2025 10:16
lvirbalas
lvirbalas approved these changes Jan 29, 2025
View reviewed changes
Copy link

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried manually. Works great.

adambarreiro
adambarreiro reviewed Jan 29, 2025
View reviewed changes
Copy link
Contributor

@adambarreiro adambarreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First scan

@Didainius
Address comments
ccf416c 
Signed-off-by: Dainius <[email protected]>
adambarreiro
adambarreiro approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@adambarreiro adambarreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Didainius
Bump SDK
2b21aee 
Signed-off-by: Dainius <[email protected]>
@Didainius
Add missing resource
4b22e34 
Signed-off-by: Dainius <[email protected]>
@Didainius Didainius merged commit 4928eb4 into vmware:main Jan 30, 2025
2 checks passed
@Didainius Didainius deleted the org-region-network-vpc-qos branch January 30, 2025 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adambarreiro adambarreiro adambarreiro approved these changes

+1 more reviewer

@lvirbalas lvirbalas lvirbalas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Didainius @adambarreiro @lvirbalas