Skip to content

Fix TestAccDataSourceNotFound test #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adambarreiro merged 18 commits into from
Feb 4, 2025
Merged

Fix TestAccDataSourceNotFound test #27

adambarreiro merged 18 commits into from
Feb 4, 2025

Conversation

@adambarreiro
Copy link
Contributor

@adambarreiro adambarreiro commented Jan 31, 2025 •
edited
Loading

Fixes failures:

FAIL: TestAccDataSourceNotFound/vcfa_certificate (0.60s) ---
FAIL: TestAccDataSourceNotFound/vcfa_org_local_user (0.18s) ---
FAIL: TestAccDataSourceNotFound/vcfa_org_regional_networking_vpc_qos (0.19s)

Also bumps SDK to an alpha tag, which was not done in #26. To avoid these mistakes, I added also a GitHub action that checks that no replace is in go.mod when a PR approval event is triggered.

I think changelog entry is not needed here as nothing new is introduced, but let me know otherwise.

@adambarreiro adambarreiro self-assigned this Jan 31, 2025
#
8c80a5b 
Signed-off-by: abarreiro <[email protected]>
@adambarreiro adambarreiro marked this pull request as ready for review January 31, 2025 09:11
abarreiro added 9 commits January 31, 2025 10:20
test
8909f5b 
Signed-off-by: abarreiro <[email protected]>
test
3aa563a 
Signed-off-by: abarreiro <[email protected]>
test
c305494 
Signed-off-by: abarreiro <[email protected]>
test
5148ac1 
Signed-off-by: abarreiro <[email protected]>
test
f8aa545 
Signed-off-by: abarreiro <[email protected]>
test
dfb317f 
Signed-off-by: abarreiro <[email protected]>
Rename wrong file
220b2f6 
Signed-off-by: abarreiro <[email protected]>
#
37b0f2b 
Signed-off-by: abarreiro <[email protected]>
#
bf9f942 
Signed-off-by: abarreiro <[email protected]>
Didainius
Didainius approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@Didainius Didainius left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixes. Maybe a note in changelog for catching the replace directive

abarreiro added 3 commits February 3, 2025 11:25
Changelog
54ef80b 
Signed-off-by: abarreiro <[email protected]>
test
3a40816 
Signed-off-by: abarreiro <[email protected]>
test
0cda15c 
Signed-off-by: abarreiro <[email protected]>
abarreiro added 4 commits February 4, 2025 11:08
test
e3afed3 
Signed-off-by: abarreiro <[email protected]>
test
2446619 
Signed-off-by: abarreiro <[email protected]>
test
94dc321 
Signed-off-by: abarreiro <[email protected]>
test
34a7070 
Signed-off-by: abarreiro <[email protected]>
@adambarreiro adambarreiro merged commit 826e662 into vmware:main Feb 4, 2025
2 checks passed
@adambarreiro adambarreiro deleted the fix-ds-not-found branch February 4, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@lvirbalas lvirbalas lvirbalas approved these changes

@Didainius Didainius Didainius approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@adambarreiro adambarreiro

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adambarreiro @lvirbalas @Didainius