-
Notifications
You must be signed in to change notification settings - Fork 5
Use a container ClientContainer for meta interface{} to extend
#29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Dainius <[email protected]>
Signed-off-by: Dainius <[email protected]>
… 'Version' Signed-off-by: Dainius <[email protected]>
Signed-off-by: Dainius <[email protected]>
Signed-off-by: Dainius <[email protected]>
Signed-off-by: Dainius <[email protected]>
MetaContainer for meta interface{} to extend ClientContainer for meta interface{} to extend
Signed-off-by: Dainius <[email protected]>
Signed-off-by: Dainius <[email protected]>
Signed-off-by: Dainius <[email protected]>
adambarreiro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Dainius <[email protected]>
lvirbalas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, just PR still mentions "meta" :)
The parts of |
This code contains many search/replace things, but core change is in
provider.goThe root thing is that the
meta interface{}attribute will betype ClientContainerinstead of*VCDClient.Instead it is:
Such approach allows us to expand the
metaargument that is used in all SDK method with additional structures that might be required.The difference for consumption is that it becomes:
instead of:
in each SDK consuming
Tests passed without any panics which should confirm that there are no missing replacements.