Skip to content

Conversation

@adambarreiro
Copy link
Contributor

@adambarreiro adambarreiro commented Feb 6, 2025

This PR:

  • Adds a new Set argument to vcfa_org_region_quota named region_vm_class_ids that allows to assign VM classes to the Region Quota.
  • Adds a new data source vcfa_region_vm_class to fetch these VM Classes from an existing Region.
  • Adds a new Set argument to vcfa_org_region_quota named region_storage_policy that allows assigning Region Storage Policies to the given Region Quota.
  • Renames vcfa_org_vdc to vcfa_org_region_quota and all Vdc, VDC, vdc occurrences to new Region Quota naming.
  • vdc parameter from Provider configuration is removed as it doesn't make much sense.

Required new properties in vcfa_test_config.json:

"tm": {
    "regionVmClasses": ["best-effort-4xlarge", "best-effort-8xlarge"],
}

Signed-off-by: abarreiro <[email protected]>
@adambarreiro adambarreiro self-assigned this Feb 6, 2025
abarreiro added 24 commits February 6, 2025 14:41
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
#
Signed-off-by: abarreiro <[email protected]>
#
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
#
Signed-off-by: abarreiro <[email protected]>
#
Signed-off-by: abarreiro <[email protected]>
#
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
#
Signed-off-by: abarreiro <[email protected]>
#
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
#
Signed-off-by: abarreiro <[email protected]>
@adambarreiro adambarreiro marked this pull request as ready for review February 12, 2025 08:16
Signed-off-by: abarreiro <[email protected]>
Copy link
Contributor

@Didainius Didainius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: abarreiro <[email protected]>
Copy link

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried manually. Works beautifully.

Signed-off-by: abarreiro <[email protected]>
@adambarreiro adambarreiro merged commit ea67864 into vmware:main Feb 12, 2025
3 checks passed
@adambarreiro adambarreiro deleted the fix-vdc branch February 12, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants