-
Notifications
You must be signed in to change notification settings - Fork 5
Add Subscribed Content Library test + vcfa_org_settings (required) + fixes #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Didainius
reviewed
Mar 5, 2025
Contributor
Didainius
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still have to test out
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Didainius
approved these changes
Mar 6, 2025
Signed-off-by: abarreiro <[email protected]>
lvirbalas
reviewed
Mar 6, 2025
lvirbalas
approved these changes
Mar 6, 2025
lvirbalas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment and looks great!
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a Subscribed Content Library test case to the existing ones.
A
PROVIDERSubscribed Content Library is trivial, butTENANTSubscribed Content Libraries required having avcfa_org_settingsresource (which is included in this PR) to allow subscribed libraries in tenants.Other fixes:
files_pathstofile_pathsvcfa_org_ldapargumentgroup_back_link_identifierto Optional as docs statevcfa_org_ldapargumentcustom_ui_button_labelauthentication_methodin LDAP resources