Skip to content

Conversation

@adambarreiro
Copy link
Contributor

@adambarreiro adambarreiro commented Mar 4, 2025

This PR adds a Subscribed Content Library test case to the existing ones.

A PROVIDER Subscribed Content Library is trivial, but TENANT Subscribed Content Libraries required having a vcfa_org_settings resource (which is included in this PR) to allow subscribed libraries in tenants.

Other fixes:

abarreiro added 2 commits March 4, 2025 16:22
Signed-off-by: abarreiro <[email protected]>
@adambarreiro adambarreiro self-assigned this Mar 4, 2025
abarreiro added 4 commits March 4, 2025 16:45
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
#
Signed-off-by: abarreiro <[email protected]>
#
Signed-off-by: abarreiro <[email protected]>
@adambarreiro adambarreiro marked this pull request as ready for review March 4, 2025 16:52
abarreiro added 4 commits March 5, 2025 13:05
Signed-off-by: abarreiro <[email protected]>
#
Signed-off-by: abarreiro <[email protected]>
nit
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
@adambarreiro adambarreiro changed the title Add Subscribed Content Library test + vcfa_org_settings (required) Add Subscribed Content Library test + vcfa_org_settings (required) + fixes Mar 5, 2025
abarreiro added 2 commits March 5, 2025 13:31
#
Signed-off-by: abarreiro <[email protected]>
#
Signed-off-by: abarreiro <[email protected]>
Copy link
Contributor

@Didainius Didainius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still have to test out

abarreiro added 2 commits March 5, 2025 21:38
Signed-off-by: abarreiro <[email protected]>
#
Signed-off-by: abarreiro <[email protected]>
fmt
Signed-off-by: abarreiro <[email protected]>
Copy link

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment and looks great!

abarreiro added 2 commits March 6, 2025 15:09
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
@adambarreiro adambarreiro merged commit fdab1c4 into vmware:main Mar 6, 2025
3 checks passed
@adambarreiro adambarreiro deleted the add-subscribed-test branch March 6, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants