Skip to content

Conversation

@adambarreiro
Copy link
Contributor

@adambarreiro adambarreiro commented Mar 19, 2025

This PR improves documentation and onboards some guides. More PRs like this one will come, as this one just covers:

  • vcfa_api_token
  • vcfa_certificate
  • vcfa_content_library

Also adjusts vcfa_content_library to always require an org_id, even for System org, to be aligned with vcfa_certificate.

To run all modified tests:

go test -tags functional -vcfa-add-provider -run '^TestAccVcfaContentLibrary' -v -timeout 0

Tests should pass

abarreiro added 4 commits March 19, 2025 10:36
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
@adambarreiro adambarreiro self-assigned this Mar 19, 2025
abarreiro added 10 commits March 19, 2025 12:08
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
@adambarreiro adambarreiro changed the title Improve documentation Improve documentation, part 1 Mar 19, 2025
@adambarreiro adambarreiro marked this pull request as ready for review March 19, 2025 14:57
abarreiro added 4 commits March 19, 2025 15:58
Signed-off-by: abarreiro <[email protected]>
nit
Signed-off-by: abarreiro <[email protected]>
nit
Signed-off-by: abarreiro <[email protected]>
nit
Signed-off-by: abarreiro <[email protected]>
Nit
Signed-off-by: abarreiro <[email protected]>
Copy link

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's rename the PR to something like this to reflect the contents better:
Documentation improvements (part 1) & change vcfa_content_library.org_id to required

@adambarreiro adambarreiro changed the title Improve documentation, part 1 Documentation improvements (part 1) & change vcfa_content_library.org_id to required Mar 21, 2025
abarreiro added 2 commits March 21, 2025 12:25
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
@adambarreiro adambarreiro merged commit 6a01649 into vmware:main Mar 21, 2025
3 checks passed
@adambarreiro adambarreiro deleted the review-docs branch March 21, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants