Skip to content

Conversation

@adambarreiro
Copy link
Contributor

@adambarreiro adambarreiro commented Apr 4, 2025

Before this PR, to run Content Library test one required to set SubscriptionContentLibraryUrl, which forced to create a publisher library in vCenter just for this test.

Now, the Content Library tests create the publisher library on-the-fly by leveraging ExternalProviders property and the vSphere Terraform Provider. This way we don't need the URL anymore. In exchange, we now require a vCenter Datacenter and Datastore, which are trivial to obtain and don't change frequently, also they don't need to be created for the test.

  • TestAccVcfaContentLibrary* acceptance tests pass
go test -tags functional -vcfa-skip-priority-tests -vcfa-add-provider -run '^TestAccVcfaContentLibrary(Tenant|Provider)$' -v -timeout 0
  • vcfa.TestAccVcfaContentLibrary*.tf tests pass:
make test-binary-prepare
cd vcfa/test-artifacts
./test-binary.sh names 'vcfa.TestAccVcfaContentLibraryProvider*.tf' 
./test-binary.sh names 'vcfa.TestAccVcfaContentLibraryTenant*.tf' 

Signed-off-by: abarreiro <[email protected]>
@adambarreiro adambarreiro self-assigned this Apr 4, 2025
abarreiro added 4 commits April 4, 2025 14:46
#
Signed-off-by: abarreiro <[email protected]>
#
Signed-off-by: abarreiro <[email protected]>
#
Signed-off-by: abarreiro <[email protected]>
#
Signed-off-by: abarreiro <[email protected]>
@adambarreiro adambarreiro marked this pull request as ready for review April 4, 2025 13:37
#
Signed-off-by: abarreiro <[email protected]>
Copy link

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@adambarreiro adambarreiro merged commit d735249 into vmware:main Apr 7, 2025
3 checks passed
@adambarreiro adambarreiro deleted the improve-cl-test branch April 7, 2025 08:33
adambarreiro added a commit that referenced this pull request Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants