Skip to content

Add internationalization package #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mdubya66 opened this issue Feb 24, 2016 · 6 comments
Closed

Add internationalization package #134

mdubya66 opened this issue Feb 24, 2016 · 6 comments
Assignees
Milestone

Comments

@mdubya66
Copy link
Contributor

We need to get i18n system in place before we get too far down the debt hole

@mdubya66
Copy link
Contributor Author

for MVP we have agreed to be internationalized. localized is not an MVP requirement.

@andrewtchin
Copy link
Contributor

@mdubya66
Copy link
Contributor Author

I looked at both and they seem more for extracting strings in order to localize them. What we need here is basic message catalog infrastructure and some best practices around using it, I think.

I found this https://godoc.org/golang.org/x/text/message

It says it's under construction and points to design proposal which I can't seem to access.

@andrewtchin andrewtchin self-assigned this Feb 24, 2016
@mdubya66
Copy link
Contributor Author

golang/go#12750 is the actual golang issue where it is being discussed

@mdubya66 mdubya66 added this to the v0.1 milestone Mar 1, 2016
@dougm
Copy link
Member

dougm commented Mar 11, 2016

After we get the wrapper in, we need to identify messages we want to internationalize. GUI/CLI labels that are displayed to the user seems to be the most likely place to start, such as CLI flags usage strings. Not so obvious to me is log messages.

And for distributing the log message bundles, we need a way to include these files either inside the binaries or along side them. Likely another wrapper method to locate and load said bundles. Note that it is possible to include files inside the compiled go binaries. There are several packages out there to help with this, I also have a simpler version internally if we decide to go this route.

@andrewtchin andrewtchin changed the title internationalization Add internationalization package Mar 11, 2016
@andrewtchin
Copy link
Contributor

Created follow on issue to use the new package #245

AngieCris pushed a commit to AngieCris/vic that referenced this issue Oct 9, 2017
* First wave of updates for Harbor.

* Overhauled docs about using VIC Engine and VIC Registry.

* Starting to add user doc for registry.

* Comments from Cheng about using Engine+Registry.

* Attempting to resolve conflict.

* Another attempt at resolving conflict.

* Another attempt at resolving conflict.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants