[Merged by Bors] - fix: add optional platform data to nodes (PL-000)#353
Closed
DecathectZero wants to merge 2 commits into
Closed
[Merged by Bors] - fix: add optional platform data to nodes (PL-000)#353DecathectZero wants to merge 2 commits into
DecathectZero wants to merge 2 commits into
Conversation
zhihil
approved these changes
Aug 15, 2022
Member
Author
|
bors r+ |
bors-vf Bot
pushed a commit
that referenced
this pull request
Aug 15, 2022
<!-- You can erase any parts of this template not applicable to your Pull Request. --> **Fixes or implements PL-000** ### Brief description. What is this change? I noticed in voiceflow/general-service#384 we were casting many nodes: `} as GoogleNode.Capture.Node;` `} as GoogleNode.Interaction.Node;` using `as` is usual not the best pattern and we should want to define the type so everything is expected. I looked everywhere where we write `platform: context.platform,` Co-authored-by: Tyler Han <tylerhan97@gmail.com>
|
Kudos, SonarCloud Quality Gate passed!
|
|
Pull request successfully merged into master. Build succeeded: |
bors-vf
Bot
changed the title
filipemerker
pushed a commit
that referenced
this pull request
Aug 19, 2022
<!-- You can erase any parts of this template not applicable to your Pull Request. --> **Fixes or implements PL-000** ### Brief description. What is this change? I noticed in https://github.com/voiceflow/general-service/pull/384 we were casting many nodes: `} as GoogleNode.Capture.Node;` `} as GoogleNode.Interaction.Node;` using `as` is usual not the best pattern and we should want to define the type so everything is expected. I looked everywhere where we write `platform: context.platform,` Co-authored-by: Tyler Han <tylerhan97@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes or implements PL-000
Brief description. What is this change?
I noticed in https://github.com/voiceflow/general-service/pull/384 we were casting many nodes:
} as GoogleNode.Capture.Node;} as GoogleNode.Interaction.Node;using
asis usual not the best pattern and we should want to define the type so everything is expected.I looked everywhere where we write
platform: context.platform,