-
-
Notifications
You must be signed in to change notification settings - Fork 117
Replace deprecated string interpolation usage #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Kudos, SonarCloud Quality Gate passed! |
This PR looks good to me. Can we get a new release that will support PHP 8.2 without depreciations? Also see PR #93 Thanks! |
LGTM too, and I need this update too |
Check out PR #93 while you are at it. This is a more serious issue, as the library does not work on 8.2. |
Actually I dont know about #93 issue, I used 8.2 on production and it work as expected. Just have deprecated warning like on this PR. But yeah, I hope that will be merged too. Maybe in the future I use the feature that has issue on 8.2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is good to merge for PHP 8.2 and does not affect older versions.
Thanks, version 4.8.8 is released with this fix. |
This PR replaces the now deprecated (as of PHP 8.2)
${var}
usage in string interpolation by{$var}
.Note that this change is backwards compatible with previous versions of PHP.
Reference: https://wiki.php.net/rfc/deprecate_dollar_brace_string_interpolation
This change is