Skip to content

Support job level priorityClassName#174

Merged
volcano-sh-bot merged 1 commit intovolcano-sh:masterfrom
TommyLike:feature/job_priority_class
May 16, 2019
Merged

Support job level priorityClassName#174
volcano-sh-bot merged 1 commit intovolcano-sh:masterfrom
TommyLike:feature/job_priority_class

Conversation

@TommyLike
Copy link
Copy Markdown
Contributor

@TommyLike TommyLike commented May 16, 2019

Add PriorityClassName and add it into PD Spec when creating PodGroup. Also add some UT for mutate_job

For #170

@k82cn
Copy link
Copy Markdown
Member

k82cn commented May 16, 2019

we should not modify Task's priority which is used by Task-Priority feature; we just need to set PodGroup's priorityClassName in job controller.

@TommyLike TommyLike force-pushed the feature/job_priority_class branch from 91f4c3a to e1edeeb Compare May 16, 2019 07:02
@k82cn
Copy link
Copy Markdown
Member

k82cn commented May 16, 2019

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels May 16, 2019
@volcano-sh-bot volcano-sh-bot merged commit 43c41ac into volcano-sh:master May 16, 2019
kevin-wangzefeng pushed a commit to kevin-wangzefeng/volcano that referenced this pull request Jun 28, 2019
…_class

Support job level priorityClassName
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants