Skip to content

move scheduler name out of common args#187

Merged
volcano-sh-bot merged 3 commits intovolcano-sh:masterfrom
lminzhw:option_scheduler_name
May 20, 2019
Merged

move scheduler name out of common args#187
volcano-sh-bot merged 3 commits intovolcano-sh:masterfrom
lminzhw:option_scheduler_name

Conversation

@lminzhw
Copy link
Copy Markdown
Contributor

@lminzhw lminzhw commented May 19, 2019

--scheduler is common argument now, so it can be parsed in any command ignoring that most of them do not use it at all.

So, this PR move this argument out of common argument and add it on demand for command which use it before.

And, add support for vkctl job list to list job with specified scheduler name.

@TommyLike
Copy link
Copy Markdown
Contributor

Do we have the case that a volcano job is not scheduled by kube-batch?

@lminzhw
Copy link
Copy Markdown
Contributor Author

lminzhw commented May 20, 2019

Do we have the case that a volcano job is not scheduled by kube-batch?

Following our best practice, all the job should use kube-batch.

But we have field job.spec.schedulerName to change the default behavior, so I think this logic should be supported all around.

@TommyLike
Copy link
Copy Markdown
Contributor

Do we have the case that a volcano job is not scheduled by kube-batch?

Following our best practice, all the job should use kube-batch.

But we have field job.spec.schedulerName to change the default behavior, so I think this logic should be supported all around.

Thanks
/lgtm
/approve

@volcano-sh-bot volcano-sh-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels May 20, 2019
@k82cn
Copy link
Copy Markdown
Member

k82cn commented May 20, 2019

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot merged commit 4839f14 into volcano-sh:master May 20, 2019
kevin-wangzefeng pushed a commit to kevin-wangzefeng/volcano that referenced this pull request Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants