Lint fix for admission and e2e package except dot import lint failures #234
Merged
volcano-sh-bot merged 7 commits intovolcano-sh:masterfrom Jun 25, 2019
Merged
Lint fix for admission and e2e package except dot import lint failures #234volcano-sh-bot merged 7 commits intovolcano-sh:masterfrom
volcano-sh-bot merged 7 commits intovolcano-sh:masterfrom
Conversation
nikita15p
changed the title
nikita15p
force-pushed
the
e2elintfix
branch
6 times, most recently
from
d130337 to
10b9069
Compare
Contributor
|
/lgtm |
volcano-sh-bot
added
size/M
Member
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: k82cn, nikita15p, TommyLike The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
kevin-wangzefeng
pushed a commit
to kevin-wangzefeng/volcano
that referenced
this pull request
Jun 28, 2019
Lint fix for admission and e2e package except dot import lint failures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes lint error for e2e package except for following dot import lint failures as per the comments.
test/e2e/admission.go:20:2: should not use dot imports
test/e2e/admission.go:21:2: should not use dot imports
test/e2e/cli_util.go:24:2: should not use dot imports
test/e2e/command.go:24:2: should not use dot imports
test/e2e/command.go:25:2: should not use dot imports
test/e2e/job_controlled_resource.go:20:2: should not use dot imports
test/e2e/job_controlled_resource.go:21:2: should not use dot imports
test/e2e/job_error_handling.go:20:2: should not use dot imports
test/e2e/job_error_handling.go:21:2: should not use dot imports
test/e2e/job_plugins.go:21:2: should not use dot imports
test/e2e/job_plugins.go:22:2: should not use dot imports
test/e2e/job_scheduling.go:22:2: should not use dot imports
test/e2e/job_scheduling.go:23:2: should not use dot imports
test/e2e/mpi.go:20:2: should not use dot imports
test/e2e/mpi.go:21:2: should not use dot imports
test/e2e/predicates.go:20:2: should not use dot imports
test/e2e/predicates.go:21:2: should not use dot imports
test/e2e/queue.go:24:2: should not use dot imports
test/e2e/queue.go:25:2: should not use dot imports
test/e2e/util.go:27:2: should not use dot imports
Found 20 lint suggestions; failing.