Skip to content

UT cases for garbagecollector package#247

Merged
volcano-sh-bot merged 6 commits intovolcano-sh:masterfrom
thandayuthapani:utjob
Jun 25, 2019
Merged

UT cases for garbagecollector package#247
volcano-sh-bot merged 6 commits intovolcano-sh:masterfrom
thandayuthapani:utjob

Conversation

@thandayuthapani
Copy link
Copy Markdown
Contributor

For #168
Added UT cases for garbagecollector package

Copy link
Copy Markdown
Contributor

@nikita15p nikita15p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

func TestGarbageCollector_IsJobFinished(t *testing.T) {
namespace := "test"

testcases := []struct {
	Name        string
	Job         *v1alpha1.Job
	ExpectedVal bool
}{
	{
		Name: "Success Case",
		Job: &v1alpha1.Job{
			ObjectMeta: metav1.ObjectMeta{
				Name:      "job1",
				Namespace: namespace,
			},
			Status: v1alpha1.JobStatus{
				State: v1alpha1.JobState{
					Phase: v1alpha1.Completed,
				},
			},
		},
		ExpectedVal: true,
	},
	{
		Name: "Success Case",
		Job: &v1alpha1.Job{
			ObjectMeta: metav1.ObjectMeta{
				Name:      "job1",
				Namespace: namespace,
			},
			Status: v1alpha1.JobStatus{
				State: v1alpha1.JobState{
					Phase: v1alpha1.Running,
				},
			},
		},
		ExpectedVal: false,
	},
}

It is good to maintain different names of the test cases so as to know exactly which TC passed/failed.

@thandayuthapani
Copy link
Copy Markdown
Contributor Author

@nikita15p Thanks for noting it down, Would have missed it while writing.

@TommyLike
Copy link
Copy Markdown
Contributor

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Jun 25, 2019
@volcano-sh-bot volcano-sh-bot merged commit d7034f2 into volcano-sh:master Jun 25, 2019
kevin-wangzefeng pushed a commit to kevin-wangzefeng/volcano that referenced this pull request Jun 28, 2019
UT cases for garbagecollector package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants