Support multiple events in the lifecycle policy by Rajadeepan · Pull Request #285 · volcano-sh/volcano

Rajadeepan · 2019-07-03T13:00:13Z

Support multiple events in the lifecycle policy. updating events to list of events.
#266

This PR need to be updated with updated submodule of charts after the PR volcano-retired/charts#5 gets merged.

k82cn · 2019-07-04T01:04:42Z

This PR need to be updated with updated submodule of charts after the PR volcano-retired/charts#5 gets merged.

We need cherry-pick CRD when this PR is merged.

k82cn · 2019-07-04T01:05:38Z

 	// according to this Event.
 	// +optional
-	Event Event `json:"event,omitempty" protobuf:"bytes,2,opt,name=event"`
+	Event []Event `json:"event,omitempty" protobuf:"bytes,2,opt,name=event"`


Add a new member; we already publish this CRD; we can not change it.

Added a new member EventList

k82cn · 2019-07-04T01:07:16Z

+					break
+				}
+				if _, found := policyEvents[event]; found {
+					err = multierror.Append(err, fmt.Errorf("duplicate event %v", event))


that's ok if duplicated in the same array.

Code updated to ignore duplicates in the same array

The duplicated events are already been removed in codes of:

policyEventsList := getEventlist(policy)

?

If there are duplicate events within one policy it will be removed in the codes of:
policyEventList := getEventlist(policy)

But if there are duplicate events across different policy then
Error message will be thrown ("duplicate events %v",event)

ok, then we may need more clear error message for that since the first case is being handled automatically now.

can the error message be updated as ("duplicate events %v across different policy", event) ?

That would be good thanks.

TravisBuddy · 2019-07-05T10:29:24Z

Travis tests have failed

Hey @Rajadeepan,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: c0c60700-9f0f-11e9-9e24-3df77584075c

TravisBuddy · 2019-07-07T19:37:42Z

Travis tests have failed

Hey @Rajadeepan,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: add68ad0-a0ee-11e9-9257-c7ea9dc52f8c

TravisBuddy · 2019-07-08T00:42:48Z

Travis tests have failed

Hey @Rajadeepan,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 4d1bc270-a119-11e9-b4a0-0f4450928f2b

k82cn · 2019-07-08T01:22:39Z

+	// The EventList recorded by scheduler; the controller takes actions
+	// according to this EventList.
+	// +optional
+	EventList []Event `json:"eventlist,omitempty" protobuf:"bytes,3,opt,name=eventlist"`


Just call Events

Updated to Events

TravisBuddy · 2019-07-08T05:42:58Z

Travis tests have failed

Hey @Rajadeepan,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 3c24db80-a143-11e9-b4a0-0f4450928f2b

TommyLike · 2019-07-09T06:06:58Z

/lgtm

TommyLike · 2019-07-09T06:07:07Z

/approve

TommyLike · 2019-07-09T06:08:31Z

cc @k82cn

k82cn · 2019-07-09T06:09:07Z

/lgtm

Please also open PR for e2e test.

k82cn · 2019-07-09T07:33:49Z

/approve

volcano-sh-bot · 2019-07-09T07:34:05Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn, Rajadeepan, TommyLike

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [k82cn]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Rajadeepan · 2019-07-09T09:25:23Z

/lgtm

Please also open PR for e2e test.

ok will raise a new PR for e2e test

TommyLike · 2019-07-09T10:56:54Z

/lgtm

volcano-sh-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 3, 2019

volcano-sh-bot requested review from k82cn and kevin-wangzefeng July 3, 2019 13:00

volcano-sh-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 3, 2019

k82cn reviewed Jul 4, 2019

View reviewed changes

Rajadeepan force-pushed the mulevents branch from 5a93fdf to 225d672 Compare July 4, 2019 11:42

Rajadeepan changed the title ~~[WIP]Support multiple events in the lifecycle policy~~ Support multiple events in the lifecycle policy Jul 4, 2019

Rajadeepan changed the title ~~Support multiple events in the lifecycle policy~~ [WIP]Support multiple events in the lifecycle policy Jul 5, 2019

Rajadeepan changed the title ~~[WIP]Support multiple events in the lifecycle policy~~ Support multiple events in the lifecycle policy Jul 5, 2019

volcano-sh-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 5, 2019

Rajadeepan force-pushed the mulevents branch from 6133e1f to cb567a7 Compare July 7, 2019 19:03

k82cn reviewed Jul 8, 2019

View reviewed changes

Rajadeepan force-pushed the mulevents branch 2 times, most recently from b042b5b to aac88fc Compare July 8, 2019 05:41

Rajadeepan force-pushed the mulevents branch from aac88fc to f9d510f Compare July 8, 2019 11:16

volcano-sh-bot assigned TommyLike Jul 9, 2019

volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2019

volcano-sh-bot assigned k82cn Jul 9, 2019

volcano-sh-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 9, 2019

volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2019

Support multiple events in the lifecycle policy

50b7595

Rajadeepan force-pushed the mulevents branch from f9d510f to 50b7595 Compare July 9, 2019 08:50

volcano-sh-bot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 9, 2019

volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2019

volcano-sh-bot merged commit 0625d1a into volcano-sh:master Jul 9, 2019

Conversation

Rajadeepan commented Jul 3, 2019

Uh oh!

k82cn commented Jul 4, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Rajadeepan Jul 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TravisBuddy commented Jul 5, 2019

Travis tests have failed

TravisBuddy Request Identifier: c0c60700-9f0f-11e9-9e24-3df77584075c

Uh oh!

TravisBuddy commented Jul 7, 2019

Travis tests have failed

TravisBuddy Request Identifier: add68ad0-a0ee-11e9-9257-c7ea9dc52f8c

Uh oh!

TravisBuddy commented Jul 8, 2019

Travis tests have failed

TravisBuddy Request Identifier: 4d1bc270-a119-11e9-b4a0-0f4450928f2b

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TravisBuddy commented Jul 8, 2019

Travis tests have failed

TravisBuddy Request Identifier: 3c24db80-a143-11e9-b4a0-0f4450928f2b

Uh oh!

TommyLike commented Jul 9, 2019

Uh oh!

TommyLike commented Jul 9, 2019

Uh oh!

TommyLike commented Jul 9, 2019

Uh oh!

k82cn commented Jul 9, 2019

Uh oh!

k82cn commented Jul 9, 2019

Uh oh!

volcano-sh-bot commented Jul 9, 2019

Uh oh!

Rajadeepan commented Jul 9, 2019

Uh oh!

TommyLike commented Jul 9, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Rajadeepan Jul 8, 2019 •

edited

Loading