set the json name of exitCode#439
Merged
volcano-sh-bot merged 1 commit intovolcano-sh:masterfrom Sep 6, 2019
davidstack:master
Merged
set the json name of exitCode#439volcano-sh-bot merged 1 commit intovolcano-sh:masterfrom davidstack:master
volcano-sh-bot merged 1 commit intovolcano-sh:masterfrom
davidstack:master
Conversation
Contributor
|
Welcome @davidstack! |
volcano-sh-bot
added
the
size/XS
k82cn
reviewed
Sep 6, 2019
| // Note: only one of `Event` or `ExitCode` can be specified. | ||
| // +optional | ||
| ExitCode *int32 | ||
| ExitCode *int32 `json:"exitCode,omitempty" protobuf:"bytes,3,opt,name=exitCode"` |
Member
There was a problem hiding this comment.
Good catch!
It should be 5, 3 is used by Events :)
Contributor
Author
There was a problem hiding this comment.
got it,i have changed this.
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidstack, k82cn The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
set the json name of exitCode ,so we can specify the exitcode in the policies.
policies:
- exitCode: 137
action: RestartJob
Member
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
set the json name of exitCode ,so we can specify the exitcode in the policies.
policies:
- exitCode: 137
action: RestartJob