fix Resource Less/LessEqual

[wangyuqing4]

when i use job.yaml

apiVersion: batch.volcano.sh/v1alpha1
kind: Job
metadata:
  generateName: xxx-
spec:
  minAvailable: 1
  schedulerName: volcano
  tasks:
  - replicas: 10
    name: ta
    template:
      spec:
        containers:
        - image: "nginx:latest"
          name: mpimaster
          resources:
            requests:
              cpu: 5
              memory: 10Gi
            limits:
              cpu: 5
              memory: 10Gi

on nodes like this

apiVersion: v1
kind: Node
......
status:
  allocatable:
    cpu: "72"
    ephemeral-storage: "18903225108"
    hugepages-1Gi: "0"
    localdir: 1048600Mi
    memory: 232Gi
    pods: "110"

i use kubectl create -f job.yaml, but no pods were scheduled.

pod events:

Events:
  Type     Reason         Age                From     Message
  ----     ------         ----               ----     -------
  Warning  Unschedulable  0s (x19 over 18s)  volcano  1/10 tasks in gang unschedulable: job is not ready, 1 minAvailable, 10 Pending.

1. i read func Less/LessEqual very confused, so i edit

2. func Less, if map r.ScalarResources and rr.ScalarResources are all nil, i think should not compare, should according to cpu and memory.

3. func Less, if map r.ScalarResources nil, rr.ScalarResources is not nil and value <= minMilliScalarResources, i think is not less, should return false. in other words, rr.ScalarResources should large enough if map is not nil.

e.g.
ScalarResources request of job is nil, but ScalarResources of node Allocatable is not nil（like hugepages-1Gi: "0"）

in proportion plugin, line 136, if attr.request.Less(attr.deserved) == true {meet}, the deserved of queue can not be larger， the job can not be scheduled any more.

4. func LessEqual, the same as point 3

[TravisBuddy]

Travis tests have failed

Hey @wangyuqing4,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 604118b0-efec-11e9-983c-41f05746e0df

[k82cn]

/lgtm
/approve

[volcano-sh-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn, wangyuqing4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• pkg/scheduler/OWNERS [k82cn]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[TravisBuddy]

Hey @wangyuqing4,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 576518a0-eff5-11e9-983c-41f05746e0df

[k82cn]

resource1 < resource2 in this case?

[wangyuqing4]

yes, resource1.ScalarResources map is not nil, but value <= minMilliScalarResources, so continue, point 4

[k82cn]

how about the others, e.g. cpu, memory? we need to make sure all resources meet LessEqual.

[k82cn]

/lgtm cancel

[k82cn]

/lgtm

Thanks :)