Skip to content

Admission Refactor.#575

Merged
volcano-sh-bot merged 1 commit intovolcano-sh:masterfrom
k82cn:adm_refactor
Dec 14, 2019
Merged

Admission Refactor.#575
volcano-sh-bot merged 1 commit intovolcano-sh:masterfrom
k82cn:adm_refactor

Conversation

@k82cn
Copy link
Copy Markdown
Member

@k82cn k82cn commented Dec 1, 2019

Signed-off-by: Klaus Ma mada3@huawei.com

@volcano-sh-bot
Copy link
Copy Markdown
Contributor

volcano-sh-bot commented Dec 1, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 1, 2019
@k82cn k82cn changed the title Admission Refactor. WIP: Admission Refactor. Dec 1, 2019
@volcano-sh-bot volcano-sh-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 1, 2019
@TravisBuddy
Copy link
Copy Markdown

TravisBuddy commented Dec 1, 2019

Travis tests have failed

Hey @k82cn,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 756150b0-13e2-11ea-9fec-2bc1e44a98db

@volcano-sh-bot volcano-sh-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 1, 2019
@volcano-sh-bot volcano-sh-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 1, 2019
@TravisBuddy
Copy link
Copy Markdown

TravisBuddy commented Dec 1, 2019

Travis tests have failed

Hey @k82cn,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 24db8130-1417-11ea-b320-67c429a7bc90

@TravisBuddy
Copy link
Copy Markdown

TravisBuddy commented Dec 1, 2019

Travis tests have failed

Hey @k82cn,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 7f2c4300-1439-11ea-b320-67c429a7bc90

@k82cn k82cn force-pushed the adm_refactor branch 2 times, most recently from edc1aba to f364d60 Compare December 1, 2019 13:18
@TravisBuddy
Copy link
Copy Markdown

TravisBuddy commented Dec 1, 2019

Hey @k82cn,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 80842650-1443-11ea-b320-67c429a7bc90

@TravisBuddy
Copy link
Copy Markdown

TravisBuddy commented Dec 12, 2019

Hey @k82cn,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 9013d310-1c93-11ea-b100-ed5cc7209ba0

@volcano-sh-bot volcano-sh-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 12, 2019
@TravisBuddy
Copy link
Copy Markdown

TravisBuddy commented Dec 12, 2019

Hey @k82cn,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: d6decab0-1ca8-11ea-b100-ed5cc7209ba0

@TravisBuddy
Copy link
Copy Markdown

TravisBuddy commented Dec 12, 2019

Travis tests have failed

Hey @k82cn,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 8704dd80-1cdb-11ea-a2fb-51cb67500490

@k82cn k82cn force-pushed the adm_refactor branch 2 times, most recently from d02a4d2 to 07a3c24 Compare December 12, 2019 13:14
@TravisBuddy
Copy link
Copy Markdown

TravisBuddy commented Dec 12, 2019

Travis tests have failed

Hey @k82cn,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 7f2d8390-1ce1-11ea-a2fb-51cb67500490

@k82cn k82cn force-pushed the adm_refactor branch 2 times, most recently from c995856 to 43d234b Compare December 13, 2019 03:57
@volcano-sh-bot volcano-sh-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 13, 2019
@TravisBuddy
Copy link
Copy Markdown

TravisBuddy commented Dec 13, 2019

Travis tests have failed

Hey @k82cn,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: e5f84030-1d5c-11ea-a2fb-51cb67500490

@TravisBuddy
Copy link
Copy Markdown

TravisBuddy commented Dec 13, 2019

Travis tests have failed

Hey @k82cn,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: a5a83fa0-1d69-11ea-a2fb-51cb67500490

@k82cn k82cn changed the title WIP: Admission Refactor. Admission Refactor. Dec 13, 2019
@volcano-sh-bot volcano-sh-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 13, 2019
@TravisBuddy
Copy link
Copy Markdown

TravisBuddy commented Dec 13, 2019

Hey @k82cn,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 6db81b30-1d76-11ea-a2fb-51cb67500490

@TravisBuddy
Copy link
Copy Markdown

TravisBuddy commented Dec 13, 2019

Hey @k82cn,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 8091e5c0-1db6-11ea-a424-4f8e788bb22e

@TravisBuddy
Copy link
Copy Markdown

TravisBuddy commented Dec 13, 2019

Hey @k82cn,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 604783c0-1dbf-11ea-a424-4f8e788bb22e

@k82cn
Admission refactor.
588d1ce 
Signed-off-by: Klaus Ma <klaus1982.cn@gmail.com>
@TravisBuddy
Copy link
Copy Markdown

TravisBuddy commented Dec 14, 2019

Hey @k82cn,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 241351c0-1e34-11ea-a424-4f8e788bb22e

@k82cn k82cn added the lgtm Indicates that a PR is ready to be merged. label Dec 14, 2019
@volcano-sh-bot volcano-sh-bot merged commit 4db0bf2 into volcano-sh:master Dec 14, 2019
@k82cn k82cn mentioned this pull request Dec 15, 2019
Closed
@k82cn k82cn deleted the adm_refactor branch December 25, 2019 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevin-wangzefeng kevin-wangzefeng Awaiting requested review from kevin-wangzefeng

@quinton-hoole quinton-hoole Awaiting requested review from quinton-hoole

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@k82cn @volcano-sh-bot @TravisBuddy