Skip to content

Add arguments for action#587

Merged
volcano-sh-bot merged 1 commit intovolcano-sh:masterfrom
sivanzcw:arguments
Dec 6, 2019
Merged

Add arguments for action#587
volcano-sh-bot merged 1 commit intovolcano-sh:masterfrom
sivanzcw:arguments

Conversation

@sivanzcw
Copy link
Copy Markdown
Contributor

@sivanzcw sivanzcw commented Dec 6, 2019

  • add overCommitFactor for enqueue action

#569 Reclaim Enhancement: Enqueue action may block the process of reclaim action
#368 The threshold of enqueue action should be configurable

@volcano-sh-bot volcano-sh-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 6, 2019
@TravisBuddy
Copy link
Copy Markdown

TravisBuddy commented Dec 6, 2019

Travis tests have failed

Hey @sivanzcw,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 84d34460-17e1-11ea-95f4-abb8efddad88

@TravisBuddy
Copy link
Copy Markdown

TravisBuddy commented Dec 6, 2019

Hey @sivanzcw,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: e5de74e0-17f1-11ea-95f4-abb8efddad88

k82cn
k82cn reviewed Dec 6, 2019
View reviewed changes
Comment thread pkg/scheduler/util_test.go Outdated
configurations:
- name: enqueue
arguments:
"overCommitFactor": 1.5
Copy link
Copy Markdown
Member

@k82cn k82cn Dec 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prefer overcommit-factor :)

@k82cn
Copy link
Copy Markdown
Member

k82cn commented Dec 6, 2019

/approve

LGTM overall, just minor comments on the argument name ;)

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2019
@k82cn
Copy link
Copy Markdown
Member

k82cn commented Dec 6, 2019

LGTM, please help to resolve conflict :)

@TravisBuddy
Copy link
Copy Markdown

TravisBuddy commented Dec 6, 2019

Hey @sivanzcw,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: a6135130-17fd-11ea-95f4-abb8efddad88

@sivanzcw
Copy link
Copy Markdown
Contributor Author

sivanzcw commented Dec 6, 2019

conflict resolved

@k82cn
Copy link
Copy Markdown
Member

k82cn commented Dec 6, 2019

/approve
/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2019
@volcano-sh-bot
Copy link
Copy Markdown
Contributor

volcano-sh-bot commented Dec 6, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn, sivanzcw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@TravisBuddy
Copy link
Copy Markdown

TravisBuddy commented Dec 6, 2019

Hey @sivanzcw,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: faec56f0-1804-11ea-95f4-abb8efddad88

@volcano-sh-bot volcano-sh-bot merged commit e9f5452 into volcano-sh:master Dec 6, 2019
@k82cn k82cn mentioned this pull request Dec 10, 2019
Closed
@sivanzcw sivanzcw mentioned this pull request Dec 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hex108 hex108 Awaiting requested review from hex108

1 more reviewer

@k82cn k82cn k82cn left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@k82cn k82cn

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sivanzcw @TravisBuddy @k82cn @volcano-sh-bot