Skip to content

Rename binaries.#605

Merged
volcano-sh-bot merged 1 commit intovolcano-sh:masterfrom
k82cn:rename_bins
Dec 20, 2019
Merged

Rename binaries.#605
volcano-sh-bot merged 1 commit intovolcano-sh:masterfrom
k82cn:rename_bins

Conversation

@k82cn
Copy link
Copy Markdown
Member

@k82cn k82cn commented Dec 14, 2019

Signed-off-by: Klaus Ma klaus1982.cn@gmail.com

@volcano-sh-bot
Copy link
Copy Markdown
Contributor

volcano-sh-bot commented Dec 14, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 14, 2019
@volcano-sh-bot volcano-sh-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 14, 2019
@TravisBuddy
Copy link
Copy Markdown

TravisBuddy commented Dec 14, 2019

Travis tests have failed

Hey @k82cn,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: e39ca170-1e63-11ea-a424-4f8e788bb22e

@TravisBuddy
Copy link
Copy Markdown

TravisBuddy commented Dec 15, 2019

Hey @k82cn,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 0d43e550-1eec-11ea-8c7c-334558e6cc20

@TravisBuddy
Copy link
Copy Markdown

TravisBuddy commented Dec 19, 2019

Hey @k82cn,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 774f1d20-226b-11ea-b76a-c509dfe0ae07

@k82cn
Rename binaries.
61cfd22 
Signed-off-by: Klaus Ma <klaus1982.cn@gmail.com>
@TravisBuddy
Copy link
Copy Markdown

TravisBuddy commented Dec 20, 2019

Hey @k82cn,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: a497a4a0-22e8-11ea-8e2a-07cdc06d0399

@k82cn k82cn added the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2019
@volcano-sh-bot volcano-sh-bot merged commit 8d82937 into volcano-sh:master Dec 20, 2019
@k82cn k82cn deleted the rename_bins branch December 25, 2019 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hex108 hex108 Awaiting requested review from hex108

@kevin-wangzefeng kevin-wangzefeng Awaiting requested review from kevin-wangzefeng

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@k82cn @volcano-sh-bot @TravisBuddy