add parameters option for hosts #243
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
requested changes
May 11, 2020
| @@ -1,10 +1,12 @@ | |||
| # == Define: dhcp::host | |||
| # | |||
| # @param [Hash] parameters set different parameters like e.g. filename for the host | |||
There was a problem hiding this comment.
The type is redundant and will be read from the parameter
Suggested change
| # @param [Hash] parameters set different parameters like e.g. filename for the host | |
| # @param parameters set different parameters like e.g. filename for the host |
Comment on lines
+24
to
+25
| <% @parameters.keys.sort.each do |param| -%> | ||
| <%= param %> <%= @parameters[param] %>; |
There was a problem hiding this comment.
Untested, but I think this also works:
Suggested change
| <% @parameters.keys.sort.each do |param| -%> | |
| <%= param %> <%= @parameters[param] %>; | |
| <% @parameters.sort.each do |param, value| -%> | |
| <%= param %> <%= value %>; |
astritsinani
pushed a commit
to astritsinani/puppet-dhcp
that referenced
this pull request
May 28, 2020
… accepting ekohl suggestion, ommited the if statement
astritsinani
pushed a commit
to astritsinani/puppet-dhcp
that referenced
this pull request
May 28, 2020
… accepting ekohl suggestion, ommited the if statement
|
Dear @ghost, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
A parameters option should be added to the host resource. There are some use-cases in which this can be very helpful if you want to overwrite global parameters for a single host. (for instance the filename parameter) This implementation is very flexible.
Thank you in advance!