Litmus updates and pre-v0.14.0 work#195
Merged
Merged
Conversation
Went through the README.md for spelling/grammar/outdated info
* Inconsistence between facter and manifest os_patching.rb line 94 * _ is also in \w
* Update patch_after_healthcheck.pp * Replace notice() with out::message() * Give plan control over noop_state and runinterval * Syntax correction Forgot commas in plan parameter definitions
…hodError on .match (#181) Co-authored-by: Tim McLaughlin <mclaugtd@wwu.edu>
I have a system where yum is currently outputting this:
```
Update notice RHSA-2019:3193 (from rhel-7-server-rpms) is broken, or a bad duplicate, skipping.
You should report this problem to the owner of the rhel-7-server-rpms repository.
If you are the owner, consider re-running the same command with --verbose to see the exact data that caused the conflict.
```
The "is broken" check excludes that first line, but then I end up with `os_patching.package_updates => [ "You", "If" ]` in my facts and the system doesn't show up as patched.
So, I propose that instead of trying to `egrep -v` away a small set of known problem lines from yum, this should carefully match lines that match the pattern of the output when a yum update is available. (`${rpmname}.${arch} ${version} ${repo}` where all whitespace is variable and lines may have trailing whitespace).
* Trying to fix testing failures * Replaced deprecated '--nodes' parameter with '--targets' parameter. * Updated spec_helper_acceptance.rb * Removed trailing spaces to fix the following syntax check 'plans/patch_after_healthcheck.pp - ERROR: trailing whitespace found on line 9' * Trying to fix 'spec/spec_helper_acceptance.rb:32:5: W: Lint/UnneededDisable: Unnecessary disabling of Metrics/BlockNesting.' Co-authored-by: Tames McTigue <tames@northwestern.edu>
Co-authored-by: dru <dru.grote@neovera.com>
Hey Tony! We are deprecating the translate module and noticed that you were using it here.
Prefer AIO Puppet / Ruby if available, but use the system's version for non AIO nodes. This unbreaks the module for non-AIO installs (e.g. using the distribution packages and not the Puppetlabs ones). Co-authored-by: Tony Green <tgreen@bandcamp.tv>
when names are too long yum history truncates and replaces names by
'...'
```
ID | Login user | Date and time | Action(s) |
Altered
-------------------------------------------------------------------------------
66 | Foo ... <foo> | 2020-01-24 16:10 | Update | 1
65 | Bar ... <bar> | 2020-01-24 16:06 | Downgrade | 1
```
Thanks to stephanevalk for the regex :)
* Trying to fix testing failures * Replaced deprecated '--nodes' parameter with '--targets' parameter. * Updated spec_helper_acceptance.rb * Removed trailing spaces to fix the following syntax check 'plans/patch_after_healthcheck.pp - ERROR: trailing whitespace found on line 9' * Trying to fix 'spec/spec_helper_acceptance.rb:32:5: W: Lint/UnneededDisable: Unnecessary disabling of Metrics/BlockNesting.' Co-authored-by: Tames McTigue <tames@northwestern.edu>
Co-authored-by: dru <dru.grote@neovera.com>
Hey Tony! We are deprecating the translate module and noticed that you were using it here.
Prefer AIO Puppet / Ruby if available, but use the system's version for non AIO nodes. This unbreaks the module for non-AIO installs (e.g. using the distribution packages and not the Puppetlabs ones). Co-authored-by: Tony Green <tgreen@bandcamp.tv>
when names are too long yum history truncates and replaces names by
'...'
```
ID | Login user | Date and time | Action(s) |
Altered
-------------------------------------------------------------------------------
66 | Foo ... <foo> | 2020-01-24 16:10 | Update | 1
65 | Bar ... <bar> | 2020-01-24 16:06 | Downgrade | 1
```
Thanks to stephanevalk for the regex :)
…atching into development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.