Skip to content

Add acceptance testing, esure=>absent, simplfify#71

Merged
albatrossflavour merged 2 commits into
voxpupuli:developmentfrom
GeoffWilliams:uninstall
Sep 28, 2018
Merged

Add acceptance testing, esure=>absent, simplfify#71
albatrossflavour merged 2 commits into
voxpupuli:developmentfrom
GeoffWilliams:uninstall

Conversation

@GeoffWilliams

@GeoffWilliams GeoffWilliams commented Sep 28, 2018

Copy link
Copy Markdown
Contributor

PR ready for review:


* Add acceptance testing
* Add support for `ensure=>absent` to completely remove us
  from the system
* Simplify puppet logic somewhat
* Other misc fixes, see below

Tickets fixed:
* https://github.com/albatrossflavour/puppet_os_patching/issues/54
* https://github.com/albatrossflavour/puppet_os_patching/issues/57
* https://github.com/albatrossflavour/puppet_os_patching/issues/58
* https://github.com/albatrossflavour/puppet_os_patching/issues/66
* https://github.com/albatrossflavour/puppet_os_patching/issues/70

GeoffWilliams and others added 2 commits September 28, 2018 13:52
@GeoffWilliams
Add acceptance testing, esure=>absent, simplfify
7e07d07 
* Add acceptance testing
* Add support for `ensure=>absent` to completely remove us
  from the system
* Simplify puppet logic somewhat
* Other misc fixes, see below

Tickets fixed:
* voxpupuli#54
* voxpupuli#57
* voxpupuli#58
* voxpupuli#66
* voxpupuli#70
@albatrossflavour
Update .rubocop.yml
48e2775
albatrossflavour
albatrossflavour reviewed Sep 28, 2018
View reviewed changes
Comment thread .rubocop.yml Outdated
Style/RegexpLiteral:
Description: Community preference. See https://github.com/voxpupuli/modulesync_config/issues/168
EnforcedStyle: mixed
EnforcedStyle: percent_r

@albatrossflavour albatrossflavour Sep 28, 2018

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

@GeoffWilliams

GeoffWilliams commented Sep 28, 2018

Copy link
Copy Markdown
Contributor Author

PDK was updated too

@albatrossflavour
albatrossflavour merged commit e2dc6a5 into voxpupuli:development Sep 28, 2018
This was referenced Sep 28, 2018
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albatrossflavour albatrossflavour albatrossflavour left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GeoffWilliams @albatrossflavour