Skip to content

Conversation

@silverslice
Copy link

Fix php 8 warning of undefined variable. See issue #822

@vlakoff
Copy link
Contributor

vlakoff commented Jun 24, 2022

This bug is 10 year old, refs e8b95f1. Nice catch!

@nikeee
Copy link

nikeee commented Jun 26, 2022

Any chance to get this merged?

@peterpp
Copy link
Contributor

peterpp commented Apr 26, 2023

@vrana , could you merge this simple fix for PHP 8?

@vlakoff
Copy link
Contributor

vlakoff commented Apr 26, 2023

A possible workaround is to add locally something like:

$GLOBALS['sql'] =& $GLOBALS['jush'];

It works even if $just hasn't been assigned yet. So you can execute the above snippet before Adminer.

Of course, it would be much better to have the bug fixed upstream.

cubercsl added a commit to cubercsl/domjudge that referenced this pull request Aug 5, 2024
@peterpp
Copy link
Contributor

peterpp commented Sep 17, 2024

@vrana
Copy link
Owner

vrana commented Feb 19, 2025

Thanks.

@vrana vrana closed this Feb 19, 2025
@Letme
Copy link

Letme commented Feb 19, 2025

Can I ask why you are closing pull requests and not merging?

@vrana
Copy link
Owner

vrana commented Feb 19, 2025

I've merged it from another branch, I will publish it soon.

@vlakoff
Copy link
Contributor

vlakoff commented Feb 19, 2025

Fix committed in 501234c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants