-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix undefined variable #450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This bug is 10 year old, refs e8b95f1. Nice catch! |
|
Any chance to get this merged? |
|
@vrana , could you merge this simple fix for PHP 8? |
|
A possible workaround is to add locally something like: $GLOBALS['sql'] =& $GLOBALS['jush'];It works even if Of course, it would be much better to have the bug fixed upstream. |
See also: vrana/adminer#450 Signed-off-by: cubercsl <[email protected]>
|
Fixed also in AdminerEvo (https://github.com/adminerevo/adminerevo) |
|
Thanks. |
|
Can I ask why you are closing pull requests and not merging? |
|
I've merged it from another branch, I will publish it soon. |
|
Fix committed in 501234c. |
Fix php 8 warning of undefined variable. See issue #822