Skip to content

fix: the parent setup should be called first #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
haoqunjiang merged 1 commit into from
Mar 12, 2020
Merged

fix: the parent setup should be called first #276

haoqunjiang merged 1 commit into from
Mar 12, 2020

Conversation

@shaonialife
Copy link
Contributor

@shaonialife shaonialife commented Mar 9, 2020 •
edited
Loading

The parent setup should be called first, otherwise inject cannot get the provide data of the parent class

@LinusBorg
Copy link
Member

LinusBorg commented Mar 9, 2020

Thanks!

@haoqunjiang haoqunjiang merged commit e1491f2 into vuejs:master Mar 12, 2020
pikax pushed a commit to pikax/vue-function-api that referenced this pull request Apr 19, 2020
@shaonialife @pikax
fix: the parent setup should be called first (vuejs#276)
8ff317e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LinusBorg LinusBorg LinusBorg approved these changes

Assignees

No one assigned

Labels

PR:Bugfix PR:ready-to-merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shaonialife @LinusBorg @haoqunjiang