Skip to content

fix(runtime-dom): equal value with a leading 0 do not trigger update #10506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yyx990803 merged 5 commits into from
Apr 15, 2024
Merged

fix(runtime-dom): equal value with a leading 0 do not trigger update #10506

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fa8f257
fix(runtime-dom): equal value with a leading 0 do not trigger update
OnlyWick Mar 13, 2024
4158933
test(runtime-dom): add test
OnlyWick Mar 13, 2024
3e89a71
Update vModel.ts
yyx990803 Apr 15, 2024
9edb138
Merge branch 'main' into fix-10503
yyx990803 Apr 15, 2024
881a437
[autofix.ci] apply automated fixes
autofix-ci[bot] Apr 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/runtime-dom/src/directives/vModel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,9 +86,10 @@ export const vModelText: ModelDirective<
el[assignKey] = getModelAssigner(vnode)
// avoid clearing unresolved text. #2302
if ((el as any).composing) return

const elValue =
number || el.type === 'number' ? looseToNumber(el.value) : el.value
number || (el.type === 'number' && el.value[0] !== '0')
Comment thread
sxzz marked this conversation as resolved.
Outdated
? looseToNumber(el.value)

@yyx990803 yyx990803 Apr 15, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made two small tweaks here:

  1. This leading 0 check should apply to both type="number" and .number modifier cases
  2. The leading 0 check should not apply to decimals like 0.123.

: el.value
const newValue = value == null ? '' : value

if (elValue === newValue) {
Expand Down