Skip to content

refactor(reactivity): simplify the wrapping logic for returned values #11434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 29, 2024
Merged

refactor(reactivity): simplify the wrapping logic for returned values #11434

merged 3 commits into from
Jul 29, 2024

Conversation

jh-leong
Copy link
Member

  • reuse the isProxy and isShallow checks within the apply method

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 25, 2024 •
edited
Loading

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 94.2 kB (+4.22 kB) 35.9 kB (+1.45 kB) 32.4 kB (+1.3 kB)
vue.global.prod.js 152 kB (+5.18 kB) 55.7 kB (+1.72 kB) 49.5 kB (+1.45 kB)

Usages

Name Size Gzip Brotli
createApp 53.1 kB (+3.38 kB) 20.6 kB (+1.09 kB) 18.8 kB (+983 B)
createSSRApp 57.1 kB (+3.75 kB) 22.2 kB (+1.21 kB) 20.2 kB (+1.09 kB)
defineCustomElement 55.4 kB (+3.37 kB) 21.4 kB (+1.14 kB) 19.5 kB (+983 B)
overall 66.7 kB (+3.43 kB) 25.7 kB (+1.12 kB) 23.4 kB (+1.04 kB)

@yyx990803 yyx990803 merged commit e28c581 into vuejs:minor Jul 29, 2024
7 checks passed
@jh-leong jh-leong deleted the refactor/array branch September 27, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jh-leong @yyx990803