Revert "fix(compiler-sfc): add scoping tag to trailing universal selector"

[edison1105]

Reverts #12918

Summary by CodeRabbit

• Refactor
  • Simplified the handling of universal selectors in scoped CSS, removing special case logic for selectors like .foo *.
• Tests
  • Streamlined test cases for scoped CSS with universal selectors, reducing multiple assertions to a single, more general check.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The handling of universal selectors (*) in scoped CSS compilation was simplified by removing special rewriting logic and associated granular tests. The code no longer rewrites selectors with trailing universal selectors, and the test suite now uses a single assertion for such cases instead of multiple detailed ones.

Changes

File(s)	Change Summary
packages/compiler-sfc/src/style/pluginScoped.ts	Removed special handling and rewriting logic for universal selectors in scoped CSS selector rewriting.
packages/compiler-sfc/tests/compileStyle.spec.ts	Simplified tests for universal selector handling by consolidating multiple assertions into one.

Sequence Diagram(s)

sequenceDiagram
    participant TestRunner
    participant ScopedCSSCompiler

    TestRunner->>ScopedCSSCompiler: Compile selector with universal selector (*)
    ScopedCSSCompiler-->>TestRunner: Returns selector with only root node scoped (no special universal selector rewriting)

Loading

Possibly related PRs

• fix(compiler-sfc): add scoping tag to trailing universal selector #12918: Reverses the handling of trailing universal selectors, directly related to the simplification and removal of special rewriting logic in this PR.

Suggested labels

ready to merge, scope: sfc

Poem

In the garden of selectors, stars once had their say,
But now the universal’s path is simple, clear as day.
No more double scoping, no more special case,
Just a single rule to keep a tidy CSS space.
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d9bd436 and 7df7670.

📒 Files selected for processing (2)

• packages/compiler-sfc/__tests__/compileStyle.spec.ts (1 hunks)
• packages/compiler-sfc/src/style/pluginScoped.ts (1 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Size Report

Bundles

File	Size	Gzip	Brotli
runtime-dom.global.prod.js	101 kB	38.3 kB	34.5 kB
vue.global.prod.js	159 kB	58.5 kB	52 kB

Usages

Name	Size	Gzip	Brotli
createApp (CAPI only)	46.6 kB	18.2 kB	16.7 kB
createApp	54.5 kB	21.2 kB	19.4 kB
createSSRApp	58.8 kB	23 kB	20.9 kB
defineCustomElement	59.5 kB	22.8 kB	20.8 kB
overall	68.6 kB	26.4 kB	24 kB

[pkg-pr-new]

Open in StackBlitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@13406

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@13406

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@13406

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@13406

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@13406

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@13406

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@13406

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@13406

@vue/shared

npm i https://pkg.pr.new/@vue/shared@13406

vue

npm i https://pkg.pr.new/vue@13406

@vue/compat

npm i https://pkg.pr.new/@vue/compat@13406

commit: 7df7670