-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
feat(vapor): forwarded slots #13408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: vapor
Are you sure you want to change the base?
feat(vapor): forwarded slots #13408
Conversation
✅ Deploy Preview for vapor-repl ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@vue/compiler-core
@vue/compiler-dom
@vue/compiler-sfc
@vue/compiler-ssr
@vue/compiler-vapor
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/runtime-vapor
@vue/server-renderer
@vue/shared
vue
@vue/compat
commit: |
340d140
to
1854562
Compare
b5f3287
to
1b849a3
Compare
1b849a3
to
c23d635
Compare
4565cf0
to
68577ca
Compare
68577ca
to
dcf927f
Compare
Maximum call stack size exceeded
occurredPlayground with this PR
foo
is a forwarded slot, it is executed, thecurrentInstance
increateSlot
is the instance ofComp
, but it should be the instance ofComp1
.Therefore, we need to preserve the current component's instance for forwarded slots and use it in
createSlot
, similar to howwithCtx
works in VDOM slots. With this PR, the compiled code changes to:Inside the
forwardedSlotCreator
, thecurrentInstance
is retained and a function is returned, which calls createSlot and passes the retained instance.