Skip to content

Communicate that feedback is welcome only but not PRs yet #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 task
bencodezen opened this issue Jul 14, 2020 · 2 comments · Fixed by #199
Closed
1 task

Communicate that feedback is welcome only but not PRs yet #171

bencodezen opened this issue Jul 14, 2020 · 2 comments · Fixed by #199
Assignees
@bencodezen

Comments

@bencodezen
Copy link
Member

  • Feedback is welcome but no PRs at this moment since the docs team is still in progress with some sections
@bencodezen
Copy link
Member Author

@phanan @NataliaTepluhina @sdras

At first, I thought maybe we'd put this message somewhere on the site, but maybe it'd be best just to add it as a PR template? Or maybe we should add some messaging somewhere that's like:

"Feedback welcome via GitHub issues, but please hold off on any pull requests as the docs are still in development and not ready for additional contributions."

@NataliaTepluhina
Copy link
Member

@bencodezen I would add this to Contributing to docs section, PR template and also I would remove Edit on GitHub link for now from the Vuepress site

@bencodezen bencodezen self-assigned this Jul 16, 2020
bencodezen added a commit that referenced this issue Jul 16, 2020
@bencodezen
config (#171): add PR template to prevent PRs at the moment
ecae58f
bencodezen added a commit that referenced this issue Jul 16, 2020
@bencodezen
config (#171): disable edit links on page temporarily
4dc03aa
@bencodezen bencodezen mentioned this issue Jul 16, 2020
Merged
NataliaTepluhina pushed a commit that referenced this issue Jul 17, 2020
@bencodezen
config (#171): reduce PRs through template and edit link removal (#199)
37a7e68 
* config (#171): add PR template to prevent PRs at the moment

* config (#171): disable edit links on page temporarily
@wxsms wxsms mentioned this issue Aug 12, 2021
Closed
TalexDreamSoul pushed a commit to Talexs/docs that referenced this issue Apr 17, 2022
@Jinjiang @wxsms
Update the translation of composable (vuejs#118) (vuejs#171)
a2a2255 
Co-authored-by: wxsm <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bencodezen bencodezen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

config (#171): reduce PRs through template and edit link removal vuejs/docs
2 participants
@bencodezen @NataliaTepluhina