Added more breaking changes to migration intro #189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
According to the Adoption strategy,
There are breaking changes in this one too, listed in the Drawbacks part. |
Member
Author
|
@Justineo valid arguments! Point proved 😅 I've updated the description with these two points |
bencodezen
reviewed
Jul 16, 2020
bencodezen
approved these changes
Jul 16, 2020
Member
bencodezen
left a comment
bencodezen
left a comment
There was a problem hiding this comment.
Just a minor update to a heading that I think will prevent some confusion, but otherwise thanks for taking the lead on this and great work!
TalexDreamSoul
pushed a commit
to Talexs/docs
that referenced
this pull request
Apr 17, 2022
* fixed: slots.md * Apply suggestions from code review * Update src/guide/components/slots.md Co-authored-by: wxsm <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few changes marked as
breakingon https://github.com/vuejs/rfcs/pulls?q=is%3Apr+is%3Amerged+label%3Acore+label%3A%22breaking+change%22 but not listed:breakingv-modelchanges)Please let me know if I was wrong in my assumptions so we could fix the list.
Netlify preview