Skip to content

Remove claim that vue scores 100% in the Custom Elements Everywhere tests #2040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

DerZade
Copy link

@DerZade DerZade commented Oct 18, 2022

Description of Problem

Vue doesn't actually score a perfect 100% in the Custom Elements Everywhere tests 😅 (see here)

Additional Information

vuejs/core#5401 is closed with a wontfix label, so I assume the test results won't change anytime soon, hence the false claim should be removed.

@netlify
Copy link

netlify bot commented Oct 18, 2022

Deploy Preview for vuejs ready!

Name Link
🔨 Latest commit 59cf765
🔍 Latest deploy log https://app.netlify.com/sites/vuejs/deploys/634e8efb7c53ce000a2cf053
😎 Deploy Preview https://deploy-preview-2040--vuejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@DerZade DerZade changed the title Update web-components.md Remove claim that vue scores 100% in the Custom Elements Everywhere tests Oct 18, 2022
@skirtles-code
Copy link
Contributor

There was a PR to update the docs previously, #1890, but it wasn't merged because the problem was fixed in 3.2.38 by commit vuejs/core@0739f89. As far as I'm aware, the latest version of Vue would score 100% but the results on Custom Elements Everywhere were run against an older version.

@DerZade
Copy link
Author

DerZade commented Oct 18, 2022

There was a PR to update the docs previously, #1890, but it wasn't merged because the problem was fixed in 3.2.38 by commit vuejs/core@0739f89. As far as I'm aware, the latest version of Vue would score 100% but the results on Custom Elements Everywhere were run against an older version.

Sorry, I didn't see the previous PR, but I think the problem still persists.
At least using the SFC Playground example provided in the original issue and just changing the version to Vue v3.2.41 suggests that.

Disclaimer: I haven't done any further testing. I just saw the issue, saw it was closed with wontfix and checked the provided reproduction link with the latest version.

@skirtles-code
Copy link
Contributor

skirtles-code commented Oct 18, 2022

I've updated my comment at vuejs/core#5401 (comment). I've included some demos of my own as the original reproduction doesn't have the required isCustomElement setting.

Note that the wontfix label was added really early on, long before Evan committed a fix. If you take a look at the commit you'll see a comment at the top of packages/vue/__tests__/customElementCasing.spec.ts that lists all the issues it's supposed to resolve, which includes 5401.

@DerZade
Copy link
Author

DerZade commented Oct 19, 2022

Okidokie.

Thanks a lot for the clarification :D

Maybe someone should tell the Custom Elements Everywhere guys, but I guess they will see your comment in the issue.

@DerZade DerZade closed this Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants