Skip to content

feat: migrate examples - #397

Merged
NataliaTepluhina merged 18 commits into
vuejs:masterfrom
marina-mosti:feat/migrate-examples
Aug 16, 2020
Merged

feat: migrate examples#397
NataliaTepluhina merged 18 commits into
vuejs:masterfrom
marina-mosti:feat/migrate-examples

Conversation

@marina-mosti

@marina-mosti marina-mosti commented Aug 10, 2020

Copy link
Copy Markdown
Collaborator

Migrated most of the examples from Vue 2 to Vue 3 docs and into codepen

Note:

  • Deepstream was removed due to missing API keys and API going into maintenance only
  • Firebase + Validation was not ported due to vuefire not being 3.x ready. Confirmed with Posva
  • Hackernews clone left for another PR due to complexity

These few should get us up and running with working examples for the docs though!

Issue: #25

@marina-mosti marina-mosti added the content Issues / PRs related to docs content label Aug 10, 2020

@NataliaTepluhina NataliaTepluhina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marina-mosti thank you so much for migrating it! I forked all examples to Vue codepen profile and added them as suggestions, could you please accept them? Rest LGTM 馃憤馃徎

Comment thread src/examples/commits.md Outdated
Comment thread src/examples/grid-component.md Outdated
Comment thread src/examples/modal.md Outdated
Comment thread src/examples/select2.md Outdated
Comment thread src/examples/svg.md Outdated
Comment thread src/examples/todomvc.md Outdated
Comment thread src/examples/tree-view.md Outdated
marina-mosti and others added 7 commits August 12, 2020 15:22
Co-authored-by: Natalia Tepluhina <tarya.se@gmail.com>
Co-authored-by: Natalia Tepluhina <tarya.se@gmail.com>
Co-authored-by: Natalia Tepluhina <tarya.se@gmail.com>
Co-authored-by: Natalia Tepluhina <tarya.se@gmail.com>
Co-authored-by: Natalia Tepluhina <tarya.se@gmail.com>
Co-authored-by: Natalia Tepluhina <tarya.se@gmail.com>
Co-authored-by: Natalia Tepluhina <tarya.se@gmail.com>
@sdras

sdras commented Aug 12, 2020

Copy link
Copy Markdown
Member

Wow, Marina, thank you so much, this is so helpful!

@NataliaTepluhina
NataliaTepluhina merged commit 35b4a9b into vuejs:master Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content Issues / PRs related to docs content

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants