feat: migrate examples #397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NataliaTepluhina
requested changes
Aug 12, 2020
There was a problem hiding this comment.
@marina-mosti thank you so much for migrating it! I forked all examples to Vue codepen profile and added them as suggestions, could you please accept them? Rest LGTM 👍🏻
Co-authored-by: Natalia Tepluhina <[email protected]>
Co-authored-by: Natalia Tepluhina <[email protected]>
Co-authored-by: Natalia Tepluhina <[email protected]>
Co-authored-by: Natalia Tepluhina <[email protected]>
Co-authored-by: Natalia Tepluhina <[email protected]>
Co-authored-by: Natalia Tepluhina <[email protected]>
Co-authored-by: Natalia Tepluhina <[email protected]>
|
Wow, Marina, thank you so much, this is so helpful! |
NataliaTepluhina
approved these changes
Aug 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated most of the examples from Vue 2 to Vue 3 docs and into codepen
Note:
vuefirenot being 3.x ready. Confirmed with PosvaThese few should get us up and running with working examples for the docs though!
Issue: #25