Repository navigation
Add app.provide to the API reference - #411
Merged
Merged
Conversation
NataliaTepluhina
approved these changes
Aug 16, 2020
NataliaTepluhina
left a comment
NataliaTepluhina
left a comment
Member
There was a problem hiding this comment.
@skirtles-code thank you, this is a great addition! 馃憤馃徎
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses problems raised in #406. Specifically:
app.providein the migration guide.app.provideto the API reference. This had been documented previously but the majority of the text described the wrong feature so it was removed in Reword Vue instance/application parameters mentions聽#355. I have retained some small parts of that previous entry but the majority is new.I believe it would also be beneficial to mention
app.provideelsewhere in the documentation, such as in the introductory guide toprovide/injectand in the API reference section for theprovide&injectoptions. I haven't undertaken that as part of this PR but I would be happy to attempt it if you feel it would be appropriate.