Skip to content

Render Functions & JSX #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
May 8, 2020
Merged

Render Functions & JSX #63

merged 13 commits into from
May 8, 2020

Conversation

znck
Copy link
Member

@znck znck commented Apr 5, 2020 •
edited
Loading

This PR is a rough draft of a new render function API.

Scope of this PR:

  • Move compatible sections from old documentation
  • Update examples to use new API
  • Remove extra/irrelevant sections
  • Reorder/rearrange information in a more comprehensible manner
  • Add missing sections
  • Replace outdated sections

@znck znck changed the title Render Functions & JSX [Rough Draft] Render Functions & JSX Apr 8, 2020
@znck znck marked this pull request as ready for review April 15, 2020 05:07
@znck znck requested a review from NataliaTepluhina April 15, 2020 05:09
@znck znck changed the title [Rough Draft] Render Functions & JSX Render Functions & JSX [first draft] Apr 15, 2020
@NataliaTepluhina NataliaTepluhina added content Issues / PRs related to docs content enhancement New feature or request labels Apr 15, 2020
@NataliaTepluhina NataliaTepluhina added this to the alpha milestone Apr 15, 2020
NataliaTepluhina
NataliaTepluhina reviewed Apr 16, 2020
View reviewed changes
Copy link
Member

@NataliaTepluhina NataliaTepluhina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @znck ! I've left a few comments

@znck znck requested review from NataliaTepluhina and phanan May 7, 2020 03:31
phanan
phanan approved these changes May 7, 2020
View reviewed changes
@znck znck changed the title Render Functions & JSX [first draft] Render Functions & JSX May 7, 2020
NataliaTepluhina
NataliaTepluhina reviewed May 7, 2020
View reviewed changes
Copy link
Member

@NataliaTepluhina NataliaTepluhina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @znck! I've left a few nitpicks to consider

src/guide/render-function.md Outdated
<div>
<h1>My title</h1>
Some text content
<!-- TODO: Add tagline -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: do we still need this TODO?

Copy link
Member Author

@znck znck May 8, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is part of the example taken from the old documentation (displayed as the DOM tree figure).

znck
znck commented May 8, 2020
View reviewed changes
@znck znck force-pushed the render-function-api branch from 768b339 to 05dddc0 Compare May 8, 2020 05:07
NataliaTepluhina
NataliaTepluhina approved these changes May 8, 2020
View reviewed changes
Copy link
Member

@NataliaTepluhina NataliaTepluhina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we're ready to merge now! 💪

@NataliaTepluhina NataliaTepluhina merged commit de54130 into master May 8, 2020
@znck znck deleted the render-function-api branch May 8, 2020 06:32
@Jinjiang
Copy link
Member

Jinjiang commented Jul 4, 2020

@NataliaTepluhina Sorry for being late. But I feel we should introduce more details about VNode. I found myself stuck on this when I'm writing something special.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phanan phanan phanan approved these changes

@NataliaTepluhina NataliaTepluhina NataliaTepluhina approved these changes

Assignees
No one assigned
Labels
content Issues / PRs related to docs content enhancement New feature or request
Projects
None yet
Milestone
alpha
Development

Successfully merging this pull request may close these issues.
4 participants
@znck @Jinjiang @phanan @NataliaTepluhina