Skip to content

Feature/84 add netlify to footer #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 21, 2020
Merged

Conversation

bencodezen
Copy link
Member

@bencodezen bencodezen commented May 9, 2020

With the current theme, the styles from the existing vuejs.org site makes the text extremely cramped, so I've opted for a simpler stacked row layout for the MVP.

Screen Shot 2020-05-09 at 5 58 49 AM

It's totally open to changes / style improvements, but thought I'd get the ball rolling with a simple integration to start.

@bencodezen bencodezen requested a review from sdras May 9, 2020 09:59
@sdras
Copy link
Member

sdras commented May 21, 2020

Thanks Ben!

@sdras sdras merged commit e365be5 into master May 21, 2020
@phanan
Copy link
Member

phanan commented May 22, 2020

Sorry late to this. Should the Netlify link be marked with the "external" icon similar to others e.g.

image

?

@NataliaTepluhina NataliaTepluhina deleted the feature/84-add-netlify-to-footer branch July 17, 2020 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants