Lint this repo using ESLint Flat Config#2226
Merged
ota-meshi merged 2 commits intovuejs:masterfrom Jun 30, 2023
Merged
Conversation
nzakas
commented
Jun 29, 2023
69 tasks
FloEdelmann
approved these changes
Jun 30, 2023
Member
FloEdelmann
left a comment
FloEdelmann
left a comment
There was a problem hiding this comment.
Looks good from my side, thank you!
What would be the next steps? FlatCompat and eslint/use-at-your-own-risk look like they need to be changed at some point 😉
FloEdelmann
changed the title
Contributor
Author
|
@FloEdelmann yes, they'll need to be changed, but at least through ESLint v9 this code will continue to work, so there will be plenty of time to adjust as needed. |
FloEdelmann
added
the
meta
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR switches the repo to use flat config for ESLint. The goal of this exercise is to test out flat config on popular ESLint plugins to make sure things will work. To do that, I:
eslint.config.jsfile.eslintrc.jsand.eslintignoretools/updatescripts to use flat configI did not make any changes to the plugin itself, this is just the linting for this repo that was updated.
I've tested this to make sure that it outputs the same results as with the eslintrc config system, but please let me know if I missed anything.