fix(define-props-destructuring): imported props declaration does not work#2995
Merged
FloEdelmann merged 2 commits intovuejs:masterfrom Dec 22, 2025
Merged
fix(define-props-destructuring): imported props declaration does not work#2995FloEdelmann merged 2 commits intovuejs:masterfrom
FloEdelmann merged 2 commits intovuejs:masterfrom
Conversation
🦋 Changeset detectedLatest commit: 087ebb5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the vue/define-props-destructuring rule where it incorrectly handled imported props declarations (both TypeScript types and runtime objects). The rule was previously skipping validation when props were defined using imported identifiers, causing false negatives.
- Fixed the logic to properly detect when
definePropshas arguments by checking for both named props and unknown types with nodes - Added comprehensive test coverage for imported types and objects in both destructuring and non-destructuring scenarios
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
lib/rules/define-props-destructuring.js |
Updated the hasArgs check to include unknown prop types that have AST nodes, correctly handling imported props declarations |
tests/lib/rules/define-props-destructuring.js |
Added test cases for imported TypeScript types and runtime objects in both valid and invalid scenarios with different destructuring preferences |
.changeset/lemon-turtles-visit.md |
Added changeset documenting the bug fix for imported props in the destructuring rule |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #2994