Property 'suffix' does not exist on type 'MapStoresCustomization' on build

[Rusinas]

Reproduction

Steps to reproduce the bug

Trying to build my project with Pinia in it, then I got the errors from vue-tsc

> vue-tsc --noEmit && vite build

node_modules/pinia/dist/pinia.d.ts:576:132 - error TS2339: Property 'suffix' does not exist on type 'MapStoresCustomization'.

576 export declare function setMapStoreSuffix(suffix: MapStoresCustomization extends Record<'suffix', string> ? MapStoresCustomization['suffix'] : string): void;
                                                                                                                                       ~~~~~~~~

node_modules/pinia/dist/pinia.d.ts:643:102 - error TS2339: Property 'suffix' does not exist on type 'MapStoresCustomization'.

643     [Id in `${Ids}${MapStoresCustomization extends Record<'suffix', string> ? MapStoresCustomization['suffix'] : 'Store'}`]: () => Store<Id extends `${infer RealId}${MapStoresCustomization extends Record<'suffix', string> ? MapStoresCustomization['suffix'] : 'Store'}` ? RealId : string, State, Getters, Actions>;
                                                                                                         ~~~~~~~~

node_modules/pinia/dist/pinia.d.ts:643:248 - error TS2339: Property 'suffix' does not exist on type 'MapStoresCustomization'.

643     [Id in `${Ids}${MapStoresCustomization extends Record<'suffix', string> ? MapStoresCustomization['suffix'] : 'Store'}`]: () => Store<Id extends `${infer RealId}${MapStoresCustomization extends Record<'suffix', string> ? MapStoresCustomization['suffix'] : 'Store'}` ? RealId : string, State, Getters, Actions>;
                                                                                                                                                                                                                                                           ~~~~~~~~


Found 3 errors in the same file, starting at: node_modules/pinia/dist/pinia.d.ts:576

Expected behavior

Build normally

Actual behavior

Doesn't build

Additional information

[jxn-30]

Update: Fixed with #1818 and released in version 2.0.25

---

We're currently facing the same issue when trying to update TypeScript from 4.8.4 to 4.9.3: LSS-Manager/LSSM-V.4#1951 (Issue: LSS-Manager/LSSM-V.4#1963)

installed pinia Version is 2.0.24 but it happened with 2.0.23 too.

Problem is, that the interface MapStoresCustomization is empty (file: /node_modules/pinia/dist/pinia.d.ts). This is not a problem caused by compilation / packaging or else but is intended:

pinia/packages/pinia/src/mapHelpers.ts

Lines 17 to 20 in 3e4e63c

	export interface MapStoresCustomization {
	// cannot be added or it wouldn't be able to be extended
	// suffix?: string
	}

(currently latest commit).
Could this be a Problem of TypeScript because

pinia/packages/pinia/src/mapHelpers.ts

Lines 66 to 72 in 3e4e63c

	export function setMapStoreSuffix(
	suffix: MapStoresCustomization extends Record<'suffix', string>
	? MapStoresCustomization['suffix']
	: string // could be 'Store' but that would be annoying for JS
	): void {
	mapStoreSuffix = suffix
	}

doesn't seem to produce the intended Typing since the TS update.

[jxn-30]

I haven't found an issue on the TS repo for that yet so I opened one: microsoft/TypeScript#51614

[Rusinas]

Wow, this is great, thank you! Hope it will be fixed soon. Weird that only two of us faced this issue

[coader]

me too

[jxn-30]

me too

@coader the issue has been fixed via a workaround in #1818 and published with Version 2.0.25 :)

[Rusinas]

@jxn-30 you're amazing 😦