Skip to content

feat(ui): add --host option #2568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 20, 2018
Merged

feat(ui): add --host option #2568

merged 2 commits into from
Oct 20, 2018

Conversation

ykzts
Copy link
Contributor

@ykzts ykzts commented Sep 21, 2018 

$ vue ui --host 0.0.0.0
🚀  Starting GUI...
🌠  Ready on http://localhost:8000

Currently vue ui can not connect from outside. This is because it is bound to localhost.

In this Pull Request, an option is added so that it can be changed to host other than localhost.

Akryum
Akryum requested changes Sep 22, 2018
View reviewed changes
Copy link
Member

@Akryum Akryum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Could you remove the unrelated dependency changes from it please? Thanks!

@ykzts
Copy link
Contributor Author

ykzts commented Sep 22, 2018

Thanks for the PR! Could you remove the unrelated dependency changes from it please? Thanks!

done!

@ykzts
Copy link
Contributor Author

ykzts commented Sep 24, 2018

rebased

@kazupon kazupon mentioned this pull request Sep 25, 2018
Closed
@liugang
Copy link

liugang commented Sep 26, 2018

It's best to change -h to -H, because -h is use for -h, --help output usage information

option('-h, --host <host>', 'Host used for the UI server (default: localhost)')

@kazupon kazupon mentioned this pull request Sep 26, 2018
Closed
@haoqunjiang haoqunjiang added this to the Next Minor milestone Sep 28, 2018
@jevillard
Copy link

Nice feature :)

@haoqunjiang haoqunjiang merged commit be814b3 into vuejs:dev Oct 20, 2018
@ykzts ykzts deleted the host branch October 20, 2018 12:04
@wiese wiese mentioned this pull request Feb 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akryum Akryum Akryum requested changes

@kazupon kazupon kazupon approved these changes

@haoqunjiang haoqunjiang haoqunjiang approved these changes

@0xHericles 0xHericles 0xHericles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Next Minor
Development

Successfully merging this pull request may close these issues.
7 participants
@ykzts @liugang @jevillard @kazupon @Akryum @haoqunjiang @0xHericles