Skip to content

chore: better upgrade messages #3926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 11, 2019
Merged

chore: better upgrade messages #3926

merged 3 commits into from
Oct 11, 2019

Conversation

phanan
Copy link
Member

@phanan phanan commented May 1, 2019

Adding an instruction into our "Update available" message, similar to how npm and yarn handle the case.

Before:

After:

Related: #212.

@Akryum Akryum requested a review from haoqunjiang May 1, 2019 20:55
Akryum
Akryum requested changes May 1, 2019
View reviewed changes
@haoqunjiang haoqunjiang mentioned this pull request Sep 27, 2019
Closed
@haoqunjiang
Copy link
Member

Hi, I've implemented the installation detection feature on my local clone.
But I can't push it directly to this branch because of permission issues. Could you edit this PR to allow edit from maintainers? https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork#enabling-repository-maintainer-permissions-on-existing-pull-requests

@haoqunjiang haoqunjiang merged commit 81d0245 into vuejs:dev Oct 11, 2019
@phanan phanan deleted the chore/update-notify branch October 11, 2019 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akryum Akryum Akryum requested changes

@pksunkara pksunkara pksunkara approved these changes

@haoqunjiang haoqunjiang haoqunjiang approved these changes

Assignees
No one assigned
Labels
PR: New Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@phanan @haoqunjiang @pksunkara @Akryum