Support ESLint + Coffeescript #5581
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haoqunjiang
reviewed
Jun 19, 2020
| if (api.hasPlugin('typescript')) { | ||
| extensions = extensions.concat('.ts', '.tsx') | ||
| } | ||
| if (api.hasPlugin('coffee')) { |
There was a problem hiding this comment.
Here you are trying to deal with a third-party Vue CLI plugin called vue-cli-plugin-coffee. Why not just modify the ESLint options in that plugin?
| @@ -41,7 +41,7 @@ module.exports = (api, options) => { | |||
| .add(/node_modules/) | |||
| .add(path.dirname(require.resolve('@vue/cli-service'))) | |||
| .end() | |||
| .test(/\.(vue|(j|t)sx?)$/) | |||
| .test(/\.(vue|(j|t)sx?|coffee)$/) | |||
There was a problem hiding this comment.
This should also be the responsibility of the coffee plugin.
Can be achieved with this statement in chainWebpack:
config.module.rule('eslint').set('test', /\.(vue|(j|t)sx?|coffee)$/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
Other information:
Now that ESLint is legitimately supported for Coffeescript as of Coffeescript v2.5.0 (via
eslint-plugin-coffee), people using Coffeescript + Vue should be able to successfully run ESLint against their Coffeescript filesBut there have been a few issues encountered (see helixbass/eslint-plugin-coffee#27)
Specifically here, I needed to adjust the Vue CLI ESLint config to run against
.coffeefilesThese changes (plus vuejs/vue-eslint-parser#62) got ESLint working with Coffeescript in an example Vue project: https://github.com/helixbass/vue-coffee-eslint-example
But I'm not sure if further refinement is needed here for this to be flexible enough eg for projects that include
.coffeefiles but don't have ESLint configured for Coffeescript, or for "hybrid" projects that include both Coffeescript + JS?