Skip to content

test: use vitest snapshot testing, update snapshot#279

Merged
ota-meshi merged 10 commits intovuejs:masterfrom
9romise:vitest/snapshot
Feb 6, 2026
Merged

test: use vitest snapshot testing, update snapshot#279
ota-meshi merged 10 commits intovuejs:masterfrom
9romise:vitest/snapshot

Conversation

@9romise
Copy link
Contributor

@9romise 9romise commented Jan 17, 2026

  • Fix the CI
  • Replace manual updating snapshot with vitest automatic updating.
  • Remove unused scripts. We can run vitest --update or press u in an interactive vitest session to update snapshots now.
  • Remove unused deps:
    • npm-run-all
    • wait-on
    • warun

@9romise 9romise changed the title test: move to vitest snapshot test: move to vitest snapshot, update snapshot Jan 17, 2026
@9romise 9romise marked this pull request as ready for review January 17, 2026 09:57
@9romise 9romise changed the title test: move to vitest snapshot, update snapshot test: use vitest snapshot testing, update snapshot Jan 17, 2026
@9romise
Copy link
Contributor Author

9romise commented Jan 17, 2026

I can't reproduce the lint error from CI locally.

@FloEdelmann
Copy link
Member

I can't reproduce the lint error from CI locally.

Have you tried removing node_modules and re-running npm install? In the CI, always the newest versions are pulled, while npm install locally does nothing if a matching version (e.g. 1.2.3 for ^1.1.0) is already installed, even if a newer one (e.g. 1.8.7) is available.

@9romise
Copy link
Contributor Author

9romise commented Jan 20, 2026

I tried upgrading Prettier to the latest version locally, and it resolved the issue.

@FloEdelmann
Copy link
Member

@ota-meshi could you please review this, so that it unblocks #278, which in turn (after a release) would unblock vuejs/eslint-plugin-vue#3002?

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much! LGTM!
Sorry for the late reply.

@ota-meshi ota-meshi merged commit 52c3373 into vuejs:master Feb 6, 2026
8 checks passed
@9romise 9romise deleted the vitest/snapshot branch February 6, 2026 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants