Use Coffeescript-compatible template expression wrapper #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helixbass
commented
Jan 3, 2020
| @@ -1345,9 +1345,9 @@ | |||
| }, | |||
| { | |||
| "message": "Unexpected end of expression.", | |||
| "index": 76, | |||
| "index": 75, | |||
There was a problem hiding this comment.
This appears to be the accurate location data for the trailing 1 in the expression abc + (1 in test/fixtures/ast/error-message-outside/source.vue
|
Closing in favor of #62 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
We have just released Coffeescript v2.5.0 with AST support +
eslint-plugin-coffeeESLint custom parser + pluginI got a bug report from someone trying to set up ESLint in a Vue + Coffeescript project
When I looked, the problem is that in
parseExpressionBody()you are wrapping template expressions in0(...), which doesn't parse in CoffeescriptSo this PR updates to use
[...]wrapper instead of0(...)