-
Notifications
You must be signed in to change notification settings - Fork 918
img srcset compiler error. #701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Check this out. |
Close (See the above comment URL) |
I think this should not be closed, because there is a demand for this feature. I ran into the same problem and could not even solve it as proposed in the above comment URL. Error was the following (with no further details):
I experimented and found out that the But isnt the binding strategy not just a workaround and the pattern that @zhe-he posted what we would expect to work? |
Definitely should re-open. Any page gets a penalty on Google PageSpeed if not including the 1x size image, while almost all user devices today are 2x. So right now there is no acceptable solution to include images in Vue... |
Absolutely. There is no reason vue-loader should treat |
I made a PR. (#953) |
when i use
<img src="../images/card1.png" srcset="../images/[email protected] 2x,../images/[email protected] 3x" />
in .vue.
it will be compiled
<img src="dist/images/card1.png" srcset="../images/[email protected] 2x,../images/[email protected] 3x" />
.It's not a correct thing to do actually.It should be
<img src="dist/images/card1.png" srcset="dist/images/[email protected] 2x,dist/images/[email protected] 3x" />
.Can add srcset compiler?
The text was updated successfully, but these errors were encountered: