-
Notifications
You must be signed in to change notification settings - Fork 918
Support for srcset #953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for srcset #953
Conversation
Would love to have this pulled, when can I expect this? |
As a workaround I'm currently putting "vue-loader": "AndreKR/vue-loader#srcset", in my package.json. Note however, that I'm not actively monitoring |
Hi @AndreKR, I made a quick review of your code that I submitted as a PR, but I think credit fir this should be yours, so feel free to review them and update this PR. For all of those that can't wait, see https://github.com/therealpecus/vue-loader |
covers cases like: ``` <img srcset=" ../image.jpg 1x, ../image.2x.jpg 2x, ../image.1920x1280.jpg 1920w " alt="srcset on multiple lines and with extra whitespace"> ```
Also added a test for srcset.
@therealpecus Thanks for the fixes, I cherry-picked your commit into this branch. I found another issue with whitespace within the candidates. I also added a test for all three cases. Please check again. |
Hopefully this will speed up the approval process. Thanks for the further review! |
Any word on merging this? Thanks. |
bump |
Whilst this was merged, it doesn't appear to be in any stable version of vuejs loader... I'm still having to use AndreKR's forked version. Any plans? |
Any word on how to get this working? |
14 months and counting. 😥 |
This PR adds support for
<img srcset="...">
. Thesrcset
URLs are converted torequire()
s, just as<img src="...">
is, the descriptors stay untouched.