Skip to content

Warnings thrown when using Rewire #759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
matt-oconnell opened this issue Apr 5, 2017 · 2 comments · Fixed by #765
Closed

Warnings thrown when using Rewire #759

matt-oconnell opened this issue Apr 5, 2017 · 2 comments · Fixed by #765

Comments

@matt-oconnell
Copy link

Getting "named exports are not supported in *.vue files." error using newest version of vue-loader

We are using The rewire babel plugin which is causing this line to fail within vue-loader. The issue seems to be that the check within vue-loader is looking for any properties other than the default and __esModule property. Rewire inserts some extra "private" properties on the component:

screen shot 2017-04-05 at 13 03 13

A proposed fix would be to check for any "non-private" properties, while still allowing objects with properties prefixed with __ to pass this check not log an error. This may or may not be considered the responsibility of the vue-loader project but if it is, let me know and I'd be happy to make a PR

@yyx990803
Copy link
Member

Hmm this is a bit niche but I guess we can take a PR for that.

@matt-oconnell
Copy link
Author

Great, I will try and get to it within the next week or two.

matt-oconnell added a commit to matt-oconnell/vue-loader that referenced this issue Apr 8, 2017
matt-oconnell added a commit to matt-oconnell/vue-loader that referenced this issue Apr 8, 2017
yyx990803 pushed a commit that referenced this issue Apr 28, 2017
* update Chinese translation

* Do not consider private properties to be named exports (fix: #759) (#765)

* support deps registered by postcss plugins

* make keyframes scoped (close #731)

* only infer scss/sass loader when no explicit loaders have been specified (fix #790)

* 12.0.1

* Revert "make keyframes scoped (close #731)"

This reverts commit 35229b0.

* 12.0.2
BugKun pushed a commit to BugKun/mpvue-loader that referenced this issue Jun 1, 2020
BugKun pushed a commit to BugKun/mpvue-loader that referenced this issue Jun 1, 2020
* update Chinese translation

* Do not consider private properties to be named exports (fix: vuejs/vue-loader#759) (#765)

* support deps registered by postcss plugins

* make keyframes scoped (close #731)

* only infer scss/sass loader when no explicit loaders have been specified (fix #790)

* 12.0.1

* Revert "make keyframes scoped (close #731)"

This reverts commit 35229b0.

* 12.0.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants