Skip to content

/lib/selector.js code review #943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
FranckFreiburger opened this issue Aug 17, 2017 · 2 comments
Closed

/lib/selector.js code review #943

FranckFreiburger opened this issue Aug 17, 2017 · 2 comments

Comments

@FranckFreiburger
Copy link

vue-loader/lib/selector.js

Line 13 in 21fb818

var filename = path.relative(context, this.resourcePath).replace(/\..+$/, '.vue')

I just wondering if:
"..\..\webapp-test\src\views\Login.vue".replace(/\..+$/, '.vue') === ".vue"
is expected ?
@Elevista
Copy link

Elevista commented Aug 18, 2017 •
edited
Loading

#945
fixed thanks

Elevista pushed a commit to Elevista/vue-loader that referenced this issue Aug 18, 2017
fix vuejs#943, regex should consider path or file name includes dot
3be3007
@FranckFreiburger
Copy link
Author

thanks!

yyx990803 pushed a commit that referenced this issue Sep 1, 2017
@Elevista @yyx990803
fix #943, should consider path or file name includes dot (#945)
c48e6fe 
* keep path of source file in source map

* fix #943, regex should consider path or file name includes dot

* use path.extname rather than regex

* add sourceRoot option for SourceMapGenerator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Elevista @FranckFreiburger