replaceState needs third argument

[raxxarr]

Version

3.0.1

Reproduction link

https://github.com/raxxarr/router-demo.git

Steps to reproduce

• in latest Safari(OS X or iOS)
• add base element: <base href="/app/">
• set router mode: history

1. open page 1 via url: localhost:8080/app/p1
2. navigate to /app/p2 by clicking button
3. click history back button on browser

What is expected?

jump back to /app/p1

What is actually happening?

jump to /app/

---

This issue is caused by using replaceState without giving a third argument when trying to fix a Firefox scroll issue (https://github.com/vuejs/vue-router/blob/dev/src/util/scroll.js#L9)； This works fine on most browsers except for Safari.
According to whatwg spec，if the 3rd argument is not given，browser should set current url into history，but Safari set the base url.
Here is Webkit source code: https://trac.webkit.org/browser/webkit/branches/safari-605.2.8.1-branch/Source/WebCore/page/History.cpp#L157
Here is Blink source code: https://chromium.googlesource.com/chromium/blink/ /master/Source/core/frame/History.cpp#153
As is seen, what Safari do is not what we expect when we omit the 3rd argument.

Although this is not really a vue-router bug, we can add a third argument(current path) to avoid something weird happen.

ps: this bug is confirmed by Webkit https://bugs.webkit.org/show_bug.cgi?id=182678

[LinusBorg]

note: the minimal reproduction cannot reproduce the issue because I don't know how to use url to change route in JSFiddle

You can also provide a repository or use codesandbox.io, for example.

[raxxarr]

@LinusBorg I've add a demo repository to reproduce this issue.

[posva]

Thanks for reporting this. I created a PR, need to check tests and on IE to add a conditional call or not